Should There Be ANT Packages In Other Modules?
There are ANT packages in modules compiler-impl, compiler-openapi and java-runtime.
Would these be better off refactored into the ant module?
Please sign in to leave a comment.
Surely it would be better. But do you have any real problem because of that?
I do.
I want to modify the plugin but because some of it is elsewhere it creates dependency issues.
Can I make a pull request moving all the ones listed or is that going to cause problems of its own?
Could you please provide more details about these dependency issues?
'com.intellij.compiler.ant' package contains implementation of 'Generate Ant Build' action, and other plugins contribute to its implementation via com.intellij.compiler.ant.ChunkBuildExtension. So if you move these classes to 'ant' plugin, these plugins will be broken, because they don't depend on 'ant' plugin. It doesn't mean that we cannot do it, but we need to have strong reasons for that.