Cannot Get reVu To Work - Scope Syntax?

Hi,

I'm looking for a decent code review tool to use with IntelliJ.  So far, reVu looks the most promising.  

The problem is that I cannot get it to work.  My project is a simple one.  It is a collection of xml files in a directory.  When I try to use file selection - in many different combinations-  nothing is detected (below).

Two questions:
1) Is reVu the best code review tool/plugin to use?
2) If so, what am I doing wrong?

Tks,
-T

reVuBroken.gif

13 comments
Comment actions Permalink

Hi Tennis,

I'm the author of reVu plugin. The issue you are mentionning is about a native component of IntelliJ (e.g. Project Settings > Scopes), I'm not totally convinced about its behavior, but it does what I'm looking for

By default, pattern is file[*]:*//*, which matches all files. Do you see all files at this point?

Then, you may start by selecting files from tree, and then include some selections using buttons at the right (Include, ...).

Regards,

Sylvain

0
Comment actions Permalink

Hi Sylvain,

Thanks for the quick reply.  See Inline.
-T

By default, pattern is file[*]:*//*, which matches all files. Do you see all files at this point?

No.  I do not.  I cannot get the plugin to "see" files of any kind.  Here is a short recording of what happens.

0
Comment actions Permalink

Hmm. When I said I was not convinced by this component, I think I had this kind of issue: sometimes tree was not refreshed.

Have you tried with Project Settings > Scopes (just to see if issue is related to reVu or not)? Also your project seems to be composed of files at root only, maybe you could add a directory with some files to check if it is related with that.

Sylvain

0
Comment actions Permalink

You are correct. It looks like a scope problem  I get the same behavior when I try setting up a new scope.  

That is terrible.  Yours is the only decent code review tool I have found - and an IntelliJ bug prevents its use.  Should I open a YouTrac for it?

-T

0
Comment actions Permalink

Note this won't prevent you from using the plugin. Scope definition is an optional feature when defining a review, only useful when you want to restrict scope of files to be reviewed. By default, you will be able to review all files, that's all.

Sylvain

0
Comment actions Permalink

sfrancois99 wrote:

Note this won't prevent you from using the plugin. Scope definition is an optional feature when defining a review, only useful when you want to restrict scope of files to be reviewed. By default, you will be able to review all files, that's all.

Sylvain

Great! How do I use it without the scope feature?

0
Comment actions Permalink

You should follow available doc from here: https://github.com/syllant/idea-plugin-revu.

Basically:

  • create the review
  • activate it (top menu reVu > Start reviewing)
  • open files and create issues from left gutter


Sylvain

0
Comment actions Permalink

Hi Sylvain,

I hope I am just doing something wrong. I am not able to get it to work at all.  

Here is a re-install and retry.  Maybe there is something obvious I am missing.

Thanks again for all your help.

-T

0
Comment actions Permalink

Looks like a reVu bug at this point, you should raise an issue here: https://github.com/syllant/idea-plugin-revu/issues.

I understand you create a review, the review file is added to the project (dbdumper.xml), but not referenced by reVu. I never encountered this issue before.

Seems you use an IPR based project, could you check .ipr file and report content of revuProjectSettings node in raised issue (here are referenced review files, for directory based projects, definition is in .idea/misc.xml)? Also you could attach IDEA log if any error has occured ($IDEA_USER_DIR/system/log/idea.log)?

PS: Also to make your first test, you should create a Review by cloning the default one, which will provide default priorities and tags.

Sylvain

0
Comment actions Permalink

sfrancois99 wrote:

Looks like a reVu bug at this point, you should raise an issue here: https://github.com/syllant/idea-plugin-revu/issues.

ok.

Seems you use an IPR based project,

IPR?

0
Comment actions Permalink

Can't find any files of type *.ipr

0
Comment actions Permalink

From you screencast, I thought your project was stored using the legacy .ipr format. As I said otherwise, reviews definitions are stored in .idea/misc.xml.

Sylvain

0

Please sign in to leave a comment.