[ANN] PsiViewer 2.2 available

Fix for good the peek-a-boo bug (or so I hope ;) )
Added Ctrl-Shift-C action: element at caret
Now Ctrl-Shift-P action displays the element returned by
event.getDataContext().getData("psi.Element");
Added: tool window title displays current element and action.

I am thinking of implementing drill down in the property sheet. Anybody
would find this helpful?

Jacques


http://www.intellij.org/twiki/bin/view/Main/PsiViewerPlugin



3 comments
Comment actions Permalink

Hi!

Unfortunately your fix for the peek-a-boo brought back the old problem of
the editor not receiving focus if it already has it when selecting a tree
node... What I mean is the following:
1 Open a java file and the PsiViewer for the entire file
2 Focus on the editor (the caret is blinking)
3 Now click in the tree.. the editor loses focus
4 Click the tree again.. the editor gets focus
5 repeat steps 3-4 above..

dont know how to solve this.. I've tried setting the focus with
SwingUtilities.invokeLater but it still seems that the tree receives focus
after this is run, this is why I had the focus listener for the tree which
was obviously invoked after the tree got focus when it was ok to put it back
on the editor..

suggestions anyone?

regards!

/Ole


"Jacques Morel" <jacmorel@yahoo.com> wrote in message
news:ar44pf$6ol$1@is.intellij.net...

Fix for good the peek-a-boo bug (or so I hope ;) )
Added Ctrl-Shift-C action: element at caret
Now Ctrl-Shift-P action displays the element returned by
event.getDataContext().getData("psi.Element");
Added: tool window title displays current element and action.

>

I am thinking of implementing drill down in the property sheet. Anybody
would find this helpful?

>

Jacques

>
>

http://www.intellij.org/twiki/bin/view/Main/PsiViewerPlugin

>
>
>


0
Comment actions Permalink

Yep, I was feeling like this code was doing something put I could not figure
it out. So I commented it out (usually I blow away comments ;-). However
when I put it back the focus is always on the editor. Not very like the
other build-in tools window. I propose that the plugin behave the same as
others:
1) the focus stays in the tool window until ESC is pressed.
2) press ESC to go back to the editor
3) That way we can use F12 to go back to the last tool window.

There are other inconsistencies with other tool windows (structure for
example) that I believe we should fix:
4) Even in auto-hide mode, clicking on the structure move the caret in the
editor. Right now the plugin won't navigate in auto-hide mode. I guess it is
related to 1)
5) Highlighting should be immediately turned on and off when pressing the
highlight button.

I am also refactoring PsiViewerProjectComponent which now has too many
responsibilities.

Anybody working on saving the split position?

Jacques
"Ole Matzura" <ole@eviware.com> wrote in message
news:ar5879$flo$1@is.intellij.net...

Hi!

>

Unfortunately your fix for the peek-a-boo brought back the old problem of
the editor not receiving focus if it already has it when selecting a tree
node... What I mean is the following:
1 Open a java file and the PsiViewer for the entire file
2 Focus on the editor (the caret is blinking)
3 Now click in the tree.. the editor loses focus
4 Click the tree again.. the editor gets focus
5 repeat steps 3-4 above..

>

dont know how to solve this.. I've tried setting the focus with
SwingUtilities.invokeLater but it still seems that the tree receives focus
after this is run, this is why I had the focus listener for the tree which
was obviously invoked after the tree got focus when it was ok to put it

back

on the editor..

>

suggestions anyone?

>

regards!

>

/Ole

>
>

"Jacques Morel" <jacmorel@yahoo.com> wrote in message
news:ar44pf$6ol$1@is.intellij.net...

Fix for good the peek-a-boo bug (or so I hope ;) )
Added Ctrl-Shift-C action: element at caret
Now Ctrl-Shift-P action displays the element returned by
event.getDataContext().getData("psi.Element");
Added: tool window title displays current element and action.

>

I am thinking of implementing drill down in the property sheet. Anybody
would find this helpful?

>

Jacques

>
>

http://www.intellij.org/twiki/bin/view/Main/PsiViewerPlugin

>
>
>

>
>




0
Comment actions Permalink

Jacques Morel wrote:

Yep, I was feeling like this code was doing something put I could not figure
it out. So I commented it out (usually I blow away comments ;-). However
when I put it back the focus is always on the editor. Not very like the
other build-in tools window. I propose that the plugin behave the same as
others:
1) the focus stays in the tool window until ESC is pressed.
2) press ESC to go back to the editor
3) That way we can use F12 to go back to the last tool window.


Perhaps you could use the same convention that other IDEA tool windows
use? Enter highlights the selected item in the editor keeping focus in
the tool window, F4 jumps to the selected item in the editor.

Ciao,
Gordon

--
Gordon Tyler
Software Developer, R&D
Sitraka (now part of Quest Software)
"Performance is Mission Critical"

0

Please sign in to leave a comment.