idea-skeleton in JavaScriptLanguage

Hey JetBrains,

is the JFlex skeleton "idea-skeleton" file that is included with
the JavaScriptLanguage sources up to date? I have a feeling
that idea-skeleton hasn't kept up with the changes you guys
made to the way you integrate with JFlex lexers.
(specifically, getTokenStart() for example is not generated and
is not part of the .flex anymore)

Also, are you considering going to JFlex 1.4.1?

Thanks,

Vince.


3 comments
Comment actions Permalink

Yep, you're right. Sorry.
Attached is up-to-day version. Unfortunately, you won't be able to generate proper lexer with jFlex downloaded from the vendor since we patched it a bit. Namely char[] buffer buffer[idx] access generation replaced with buffer.charAt(idx) since all buffers are going to be CharSequences instead of char[]. I suspect we cannot redistribute patched jFlex due to it's license is GPL.

Hapilly, there exactly two places to patch generated file by hand.

-


Maxim Shafirov
http://www.jetbrains.com
"Develop with pleasure!"

Hey JetBrains,

>

is the JFlex skeleton "idea-skeleton" file that is included with
the JavaScriptLanguage sources up to date? I have a feeling
that idea-skeleton hasn't kept up with the changes you guys
made to the way you integrate with JFlex lexers.
(specifically, getTokenStart() for example is not generated and
is not part of the .flex anymore)
Also, are you considering going to JFlex 1.4.1?

>

Thanks,

>

Vince.

>



Attachment(s):
idea-flex.skeleton
0
Comment actions Permalink

Maxim Shafirov wrote:

Yep, you're right. Sorry.
Attached is up-to-day version. Unfortunately, you won't be able to generate proper lexer with jFlex downloaded from the vendor since we patched it a bit. Namely char[] buffer buffer[idx] access generation replaced with buffer.charAt(idx) since all buffers are going to be CharSequences instead of char[]. I suspect we cannot redistribute patched jFlex due to it's license is GPL.


IANAL, but I think this only applies to distributing it with the product. You should be able to
post it (binary + source) here though without getting in trouble as long as the patched sources
don't reference OpenAPI classes. Just my wild guess ;)

Sascha

0
Comment actions Permalink

You can redistribute patched jflex as source + binary release under the GPL

Yep, you're right. Sorry.
Attached is up-to-day version. Unfortunately, you won't be able to
generate proper lexer with jFlex downloaded from the vendor since we
patched it a bit. Namely char[] buffer buffer[idx] access generation
replaced with buffer.charAt(idx) since all buffers are going to be
CharSequences instead of char[]. I suspect we cannot redistribute
patched jFlex due to it's license is GPL.
Hapilly, there exactly two places to patch generated file by hand.

-------------------
Maxim Shafirov
http://www.jetbrains.com
"Develop with pleasure!"

>> Hey JetBrains,
>>
>> is the JFlex skeleton "idea-skeleton" file that is included with
>> the JavaScriptLanguage sources up to date? I have a feeling
>> that idea-skeleton hasn't kept up with the changes you guys
>> made to the way you integrate with JFlex lexers.
>> (specifically, getTokenStart() for example is not generated and
>> is not part of the .flex anymore)
>> Also, are you considering going to JFlex 1.4.1?
>> Thanks,
>>
>> Vince.
>>



0

Please sign in to leave a comment.