[ANN] Images Support 0.1.2

Hello,

New version available in Plugin Manager since 3260 build of Irida.
Changes:

  • Zoom and moving remaked. Moving is available only in visible ranges.

  • Optimization in background layer rendering for performance on large images.

  • Added ability to configure bacground and grid line colors

  • Bugfixes


Thanks!
--
Alexey Efimov

11 comments
Comment actions Permalink

Thanks, Alexey.

Now, can anyone from JetBrains comment on why CtrlShiftN (Open File)
doesn't seem to know about image files when this plug-in is installed?
Is it an IntelliJ bug or is there an API that Alexey needs to call in
order to make that work?

Thanks,
Amnon

Alexey Efimov wrote:

Hello,

New version available in Plugin Manager since 3260 build of Irida.
Changes:

  • Zoom and moving remaked. Moving is available only in visible ranges.

Great. Now this works as expected.

  • * Optimization in background layer rendering for performance on large images.

  • Added ability to configure bacground and grid line colors

  • Bugfixes


Thanks!
--
Alexey Efimov

0
Comment actions Permalink

We used to check FileType.isBinary() as a synonymous of file being editable
which is not the case with Alexey's plugin. Will be fixed in next build.

-


Maxim Shafirov
http://www.jetbrains.com
"Develop with pleasure!"

Thanks, Alexey.

Now, can anyone from JetBrains comment on why CtrlShiftN (Open File)
doesn't seem to know about image files when this plug-in is installed?
Is it an IntelliJ bug or is there an API that Alexey needs to call in
order to make that work?

Thanks,
Amnon
Alexey Efimov wrote:

>> Hello,
>>
>> New version available in Plugin Manager since 3260 build of Irida.
>> Changes:
>> * Zoom and moving remaked. Moving is available only in visible
>> ranges.

Great. Now this works as expected.

>> * Optimization in background layer rendering for performance on large
>> images.
>> * Added ability to configure bacground and grid line colors
>> * Bugfixes
>> Thanks!
>> --
>> Alexey Efimov



0
Comment actions Permalink

I just can't imagine how. You can't be sure that file has an editor by FileType only. I think that FileType must have linked FileDitorProviders.

0
Comment actions Permalink

We'll be filtering files, not filetypes before showing them in CtrlSHiftN.
-


Maxim Shafirov
http://www.jetbrains.com
"Develop with pleasure!"

I just can't imagine how. You can't be sure that file has an editor by
FileType only. I think that FileType must have linked
FileDitorProviders.




0
Comment actions Permalink

Totaly ignore FileType filtering on them...
But icons will be shown in list of files?

0
Comment actions Permalink

Sure
-


Maxim Shafirov
http://www.jetbrains.com
"Develop with pleasure!"

Totaly ignore FileType filtering on them...
But icons will be shown in list of files?




0
Comment actions Permalink

Doesn't work. On your side this time:

java.lang.Throwable
at com.intellij.openapi.diagnostic.Logger.error(Logger.java:34)
at com.intellij.openapi.application.impl.ApplicationImpl.assertIsDispatchThread(ApplicationImpl.java:301)
at com.intellij.openapi.application.impl.ApplicationImpl.runProcessWithProgressSynchronously(ApplicationImpl.java:266)
at com.intellij.openapi.application.impl.ApplicationImpl.runProcessWithProgressSynchronously(ApplicationImpl.java:98)
at org.intellij.imagesSupport.editor.impl.ImageFileEditorProvider.getImage(ImageFileEditorProvider.java:68)
at org.intellij.imagesSupport.editor.impl.ImageFileEditorProvider.accept(ImageFileEditorProvider.java:44)
at com.intellij.openapi.fileEditor.impl.FileEditorProviderManagerImpl.getProviders(FileEditorProviderManagerImpl.java:35)
at com.intellij.ide.util.gotoByName.GotoFileModel.a(GotoFileModel.java:16)
at com.intellij.ide.util.gotoByName.GotoFileModel.getElementsByName(GotoFileModel.java:20)
at com.intellij.ide.util.gotoByName.ChooseByNameBase$CalcElementsThread.a(ChooseByNameBase.java:9)
at com.intellij.ide.util.gotoByName.ChooseByNameBase$CalcElementsThread.access$2100(ChooseByNameBase.java:39)
at com.intellij.ide.util.gotoByName.ChooseByNameBase$15.run(ChooseByNameBase.java:1)
at com.intellij.openapi.application.impl.ApplicationImpl.runReadAction(ApplicationImpl.java:271)
at com.intellij.ide.util.gotoByName.ChooseByNameBase$CalcElementsThread.run(ChooseByNameBase.java:16)

Could you please optimize accept() method so it doesn't call getImage()?
Or at least get rid of runProcessWithProgressSynchroniously.

-


Maxim Shafirov
http://www.jetbrains.com
"Develop with pleasure!"

Totaly ignore FileType filtering on them...
But icons will be shown in list of files?




0
Comment actions Permalink

New version uploaded.
Thank you!

0
Comment actions Permalink

Thanks Alexey! CtrlShiftN works like a charm with updated Images plugin
in #3264. We'll most probably upload new build tomorrow.
-


Maxim Shafirov
http://www.jetbrains.com
"Develop with pleasure!"

New version uploaded.
Thank you!




0
Comment actions Permalink

Hello Maxim,

MS> Thanks Alexey! CtrlShiftN works like a charm with updated Images
MS> plugin
MS> in #3264. We'll most probably upload new build tomorrow.

We all look forward for new IDEA build :))

Thanks!
--
Alexey Efimov, Java Developer
Tops BI
http://www.topsbi.ru


0
Comment actions Permalink

Cool!

Now that's cooperation in action.

Thanks, Alexey and JetBrains!

Amnon

0

Please sign in to leave a comment.