FileStatus : difference between DELETED and DELETED_FROM_FS

Hi, what's the exact difference between those two statuses ?

9 comments

Hello Thibaut,

Hi, what's the exact difference between those two statuses ?


It's meant to be the following: a DELETED file has been properly scheduled
for deletion from VCS, and a DELETED_FROM_FS was deleted locally but not
scheduled for deletion from VCS. However, the DELETED_FROM_FS status is not
really used now.

--
Dmitry Jemerov
Development Lead
JetBrains, Inc.
http://www.jetbrains.com/
"Develop with Pleasure!"


0

and, what is the difference between
builder.processChange(new Change( ..., FileStatus.DELETED_FROM_FS));
equilvalent to
builder.processLocallyDeletedFile(filePath);

0

Hello Thibaut,

and, what is the difference between
builder.processChange(new Change( ...,
FileStatus.DELETED_FROM_FS));


This creates a change object. Changes can be moved between changelists, committed
etc. Typically none of these actions make sense for files which have not
been properly scheduled for deletion.

equilvalent to
builder.processLocallyDeletedFile(filePath);


This is the correct way to process this situation.

--
Dmitry Jemerov
Development Lead
JetBrains, Inc.
http://www.jetbrains.com/
"Develop with Pleasure!"


0

my current use case is actually that the vcs reports that some files have been added, but I don't have them locally.

So when I compare the working copy with the remote VCS, i get a number of "missing" files.
According to you , what would be the correct way to report those ?

0

Hello Thibaut,

my current use case is actually that the vcs reports that some files
have been added, but I don't have them locally.

So when I compare the working copy with the remote VCS, i get a number
of "missing" files. According to you , what would be the correct way
to report those ?


Where do you want them to be visibile? None of the existing VCS integrations
shows such files in the Local Changes view.

--
Dmitry Jemerov
Development Lead
JetBrains, Inc.
http://www.jetbrains.com/
"Develop with Pleasure!"


0

Thing is there is no way I know of to distinguish the following 2 cases
- the developper locally deleted a file (using the windows explorer for example)
- another developper added a file to the repository

This is because there is no project wide revisions in MKS (I guess it's quite similar to VSS on this aspect ?)

I agree that ideally the second case would be best reported using the "incoming changes" view

0

Thibaut,

Actually there is a way. It requires some rather nasty manipulation of filters and multiple invocations to si viewsandbox.

Take a look at the open-mks plugin I am working on. It reports all file statuses correctly (http://open-mks.cvs.sourceforge.net/open-mks/mks-idea/).

0

THis discussion does not belong here, but i kind of think it would be better to work together in order to provide one (very) good plugin rather than 2 mediocre ones :)

Rapidly browsing your code I discovered a feature of CLI mks i didn't know : the ability to use ! in filters, which may come in handy in some cases.

I like it that you're not using the Triclops package (with its native library), which i plan to remove from the plugin i maintain for some time, but did not achieve yet.

On the other hand, you don't seem to support change packages

ezdit : your plugin do not seem to be Selena compliant ? I get compile error on a number of IDEA OpenAPI classes when using latest EAP

Message was edited by:
Thibaut

0

Absolutely.

You are looking at a work in progress; were aiming for a release sometime within the next couple of weeks which should cover most of the bases for IDEA 6.

Change Package support is next (theres not much to it)

Selena support will become a priority once releases get rolling on the stable branch (Selena is not yet released, and I have users which are still using IDEA 6 on a regular basis).

0

Please sign in to leave a comment.