6763: Changes: Committed tab

Since the previous bug with the Committed tab in the Changes window has been fixed, I decided to try this out to see if it was an adequate replacement for TMate.

I clicked the Refresh button about 8 minutes ago and the progress dialog says that it has read nearly 22000 KB from the server so far. Around 18000KB the progress bar movement became erratic, moving in spurts every few seconds. The memory indicator says 189M of 190M, so I suspect there are very many garbage collections occurring that are slowing it down.

The most recent message in idea.log is:

2007-03-16 14:37:05,030 INFO - ort2.javacvsImpl.io.ReadThread - Starting CvsReadThread com.intellij.cvsSupport2.javacvsImpl.io.ReadThread@7abd4c, atEnd: false, firstIndex: 0, lastIndex: 0, exception: null, closed: false

5 comments

Hello Gordon,

Since the previous bug with the Committed tab in the Changes window
has been fixed, I decided to try this out to see if it was an adequate
replacement for TMate.

I clicked the Refresh button about 8 minutes ago and the progress
dialog says that it has read nearly 22000 KB from the server so far.
Around 18000KB the progress bar movement became erratic, moving in
spurts every few seconds. The memory indicator says 189M of 190M, so I
suspect there are very many garbage collections occurring that are
slowing it down.


Well, ahem, the feature's not done yet. :) For SVN and Perforce, the tab
shows the latest 50 changes, and in CVS there's no easy way to get such filtering
from the server. So it downloads everything. There is some CVS-specific local
caching, but it doesn't come into play if you haven't yet downloaded any
history.

As a workaround for the current build, you can set a date filter before clicking
on refresh.

--
Dmitry Jemerov
Software Developer
JetBrains, Inc.
http://www.jetbrains.com/
"Develop with Pleasure!"


0

I'm trying that with "after date" set to yesterday morning but it's already at 12MB data read. Our repository may be a bit of a pathological use-case though. It's over 6 years old and has seen at least one wholesale package renaming with the result that there is a lot of stuff in the Attic directories and full checkouts/updates spend a significant amount of time pruning empty directories.

It just stopped with an error now, I think it was at about 20MB read. The error is:

No message
java.lang.NullPointerException
at com.intellij.cvsSupport2.changeBrowser.RevisionWrapper.]]>(RevisionWrapper.java:14)
at com.intellij.cvsSupport2.changeBrowser.CvsChangeListsBuilder.addLogs(CvsChangeListsBuilder.java:79)
at com.intellij.cvsSupport2.changeBrowser.CvsCommittedChangesProvider.loadCommittedChanges(CvsCommittedChangesProvider.java:120)
at com.intellij.cvsSupport2.changeBrowser.CvsCommittedChangesProvider.getCommittedChanges(CvsCommittedChangesProvider.java:88)
at com.intellij.cvsSupport2.changeBrowser.CvsCommittedChangesProvider.getAllCommittedChanges(CvsCommittedChangesProvider.java:70)
at com.intellij.openapi.vcs.changes.ui.CommittedChangesPanel$1.run(CommittedChangesPanel.java:3)
at com.intellij.openapi.progress.impl.ProgressManagerImpl$2.run(ProgressManagerImpl.java:6)
at com.intellij.openapi.progress.impl.ProgressManagerImpl.executeProcessUnderProgress(ProgressManagerImpl.java:5)
at com.intellij.openapi.progress.impl.ProgressManagerImpl.runProcess(ProgressManagerImpl.java:86)
at com.intellij.openapi.application.impl.ApplicationImpl$6$1.run(ApplicationImpl.java:10)
at com.intellij.openapi.application.impl.ApplicationImpl$4.run(ApplicationImpl.java:0)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:417)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:269)
at java.util.concurrent.FutureTask.run(FutureTask.java:123)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:650)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:675)
at java.lang.Thread.run(Thread.java:595)
at com.intellij.openapi.application.impl.ApplicationImpl$1$1.run(ApplicationImpl.java:7)

0

Hello Gordon,

It just stopped with an error now, I think it was at about 20MB read.
The error is:

No message
java.lang.NullPointerException
at
com.intellij.cvsSupport2.changeBrowser.RevisionWrapper.<init>(Revision
Wrapper.java:14)
at
com.intellij.cvsSupport2.changeBrowser.CvsChangeListsBuilder.addLogs(C
vsChangeListsBuilder.java:79)


This exception no longer happens in build 6776 (released today).

--
Dmitry Jemerov
Software Developer
JetBrains, Inc.
http://www.jetbrains.com/
"Develop with Pleasure!"


0

Hello Gordon,

That was with build 6776.


Ah, indeed, I misunderstood the reason for this exception. Thanks for the
notice.

--
Dmitry Jemerov
Software Developer
JetBrains, Inc.
http://www.jetbrains.com/
"Develop with Pleasure!"


0

Please sign in to leave a comment.