7 comments

It needs an active selection in the editor.

0

It likes only plain text selections not free selections. But externalized may be any part of JSP without custom tags or EL expressions. Seems that simple tags not possible to exteranlize.

Thanks,
Dmitry

0

Yes, currently it accepts selections inside tags only.
So you should be able to i18nize text inside tag.
This way you would minimize risk to break XML wellformedness.

I can relax this requirenment by e.g. checking that your selection does not
contain unclosed tags,
so that you would be able to i18nize "xxmessage", but not "xxxmessage begin". What do you think ? -- regards, -- Alexey Kudravtsev Software Developer JetBrains, Inc, http://www.jetbrains.com "Develop with pleasure!" "Dmitry Kashin" ]]> wrote in message
news:21479822.1137763733843.JavaMail.itn@is.intellij.net...

It likes only plain text selections not free selections. But externalized
may be any part of JSP without custom tags or EL expressions. Seems that
simple tags not possible to exteranlize.

>

Thanks,
Dmitry

>



0

Hello Alexey,
It sounds reasonable. Also please accept only XHTML tags inside, not custom tags. In ideal better to behave it like regular refactoring select, then invoke and show warning why not possible to externalize.

Thanks,
Dmitry

0

By the way tags parameters may be i18nized too. So restrictions may be treated as warning with asking to proceed or cancel action.

Thanks,
Dmitry

0

Fixed

--
regards,
--
Alexey Kudravtsev
Software Developer
JetBrains, Inc, http://www.jetbrains.com
"Develop with pleasure!"

"Dmitry Kashin" <no_mail@jetbrains.com> wrote in message
news:5500824.1137765900961.JavaMail.itn@is.intellij.net...

Hello Alexey,
It sounds reasonable. Also please accept only XHTML tags inside, not
custom tags. In ideal better to behave it like regular refactoring select,
then invoke and show warning why not possible to externalize.

>

Thanks,
Dmitry



0

Thanks Alexey,
Now this feature will be more user friendly.

0

Please sign in to leave a comment.