20 more IG/IPP bugs found...


And about 30 places where I could remove unnecessary null checks. @Nullable and @NotNull deeply rule. Keep annotating the OpenAPI, guys. It's in everybody's best interest.

--Dave Griffith

3 comments
Comment actions Permalink

Do you mean you have benefitted from PSI classes annotations?
If so, I'll probably go on and annotate classes starting from letter 'D' :)

Eugene.

"Dave Griffith" <dave.griffith@cnn.com> wrote in message
news:5549240.1117833316885.JavaMail.javamailuser@localhost...
>

And about 30 places where I could remove unnecessary null checks.

@Nullable and @NotNull deeply rule. Keep annotating the OpenAPI, guys.
It's in everybody's best interest.
>

--Dave Griffith



0
Comment actions Permalink

>Do you mean you have benefitted from PSI classes annotations?

Yes. The 20 bugs found this time were places where partially-completed code would cause an NPE to be thrown during an inspection. Real pain to find those previously, but dead easy with the PSI marked up as @Nullable or @NotNull.

--Dave Griffith

0
Comment actions Permalink

Eugene Vigdorchik (JetBrains) wrote:

Do you mean you have benefitted from PSI classes annotations?
If so, I'll probably go on and annotate classes starting from letter 'D' :)


Yes, I found the annotations in PSI most useful too. In fact, if I could
have only a single api to have annotated with @Nullable and @NotNull it
would be the PSI api. It's so effective there.

Bas

0

Please sign in to leave a comment.