3311 formatting quirks

There are still some problems with formatting in 3311

In legacy code, I have many declarations that look like:


After reformatting, they now look like


When you manually break the line Idea helpfully gives you



I'll need to look through the code and see what other single line comments were joined to the following line.

17 comments
Comment actions Permalink

Not a solution to the problem, but do you have "Do not wrap one line comments" enabled? Seems like disabling this helps with this bug (too bad, I really like to keep my /** */ comments in one line if possible).

0
Comment actions Permalink

I'm still seeing IntelliJ crashes when reformatting code after pasting in
code from another java file.



"Dave Levitt" <no_mail@jetbrains.com> wrote in message
news:29126839.1114618988561.JavaMail.itn@is.intellij.net...

There are still some problems with formatting in 3311

>

In legacy code, I have many declarations that look like:
// Bspan Order Tools > BspanOrderTools bspanOrderTools; > ]]>

>

After reformatting, they now look like
// Bspan Order Tools BspanOrderTools bspanOrderTools; > ]]>

>

When you manually break the line Idea
helpfully gives you

>

// Bspan Order Tools > // BspanOrderTools bspanOrderTools; > ]]>

>

I'll need to look through the code and see what other single line comments
were joined to the following line.



0
Comment actions Permalink

Is that the 'Alignment and Braces -> Keep when reformatting -> Line breaks' setting? Or is there another setting just for single line comments

Actually, I don't want to keep any line break except for single line comments, build 2390 didn't break things, but resulted in really ugly formatting .

0
Comment actions Permalink

As an FYI, this is the stack trace I get all the time:


Attempt to modify PSI for non-commited Document!
java.lang.Throwable
at com.intellij.openapi.diagnostic.Logger.error(Logger.java:34)
at
com.intellij.psi.impl.PsiToDocumentSynchronizer.a(PsiToDocumentSynchronizer.java:16)
at
com.intellij.psi.impl.PsiToDocumentSynchronizer.childReplaced(PsiToDocumentSynchronizer.java:9)
at com.intellij.psi.impl.PsiManagerImpl.a(PsiManagerImpl.java:399)
at
com.intellij.psi.impl.PsiManagerImpl.childReplaced(PsiManagerImpl.java:452)
at
com.intellij.pom.wrappers.PsiEventWrapperAspect.update(PsiEventWrapperAspect.java:33)
at
com.intellij.pom.core.impl.PomModelImpl.runTransaction(PomModelImpl.java:43)
at com.intellij.psi.impl.source.tree.ChangeUtil.a(ChangeUtil.java:381)
at
com.intellij.psi.impl.source.tree.ChangeUtil.replaceChild(ChangeUtil.java:8)
at
com.intellij.psi.impl.source.tree.CompositeElement.replaceChild(CompositeElement.java:111)
at
com.intellij.psi.impl.source.codeStyle.CodeEditUtil.replaceChild(CodeEditUtil.java:199)
at
com.intellij.psi.impl.source.tree.CompositeElement.replaceChildInternal(CompositeElement.java:36)
at
com.intellij.psi.impl.source.tree.FileElement.replaceChildInternal(FileElement.java:3)
at
com.intellij.psi.impl.source.TreeWrapperPsiElement.replace(TreeWrapperPsiElement.java:29)
at
com.intellij.codeInsight.actions.OptimizeImportsProcessor$1.run(OptimizeImportsProcessor.java:4)
at
com.intellij.codeInsight.actions.ReformatAndOptimizeImportsProcessor$1.run(ReformatAndOptimizeImportsProcessor.java:2)
at
com.intellij.codeInsight.actions.AbstractLayoutCodeProcessor$2.run(AbstractLayoutCodeProcessor.java:2)
at
com.intellij.openapi.application.impl.ApplicationImpl.runWriteAction(ApplicationImpl.java:150)
at
com.intellij.codeInsight.actions.AbstractLayoutCodeProcessor$9$1$1.run(AbstractLayoutCodeProcessor.java:1)
at
com.intellij.openapi.command.impl.CommandProcessorImpl.executeCommand(CommandProcessorImpl.java:91)
at
com.intellij.openapi.command.impl.CommandProcessorImpl.executeCommand(CommandProcessorImpl.java:58)
at
com.intellij.codeInsight.actions.AbstractLayoutCodeProcessor$9$1.run(AbstractLayoutCodeProcessor.java:2)
at
com.intellij.openapi.application.impl.LaterInvocatorEx$FlushQueue.run(LaterInvocatorEx.


"Grant Gochnauer" <grant@gochnauer.org> wrote in message
news:d4ogvk$crm$1@is.intellij.net...

I'm still seeing IntelliJ crashes when reformatting code after pasting in
code from another java file.

>
>
>

"Dave Levitt" <no_mail@jetbrains.com> wrote in message
news:29126839.1114618988561.JavaMail.itn@is.intellij.net...

>> There are still some problems with formatting in 3311
>>
>> In legacy code, I have many declarations that look like:
>> > // Bspan Order Tools >> BspanOrderTools bspanOrderTools; >> ]]>
>>
>> After reformatting, they now look like
>> > // Bspan Order Tools BspanOrderTools bspanOrderTools; >> ]]>
>>
>> When you manually break the line Idea
>> helpfully gives you
>>
>> > // Bspan Order Tools >> // BspanOrderTools bspanOrderTools; >> ]]>
>>
>> I'll need to look through the code and see what other single line
>> comments were joined to the following line.
>



0
Comment actions Permalink

I agree, typing code is seriously broken in 3311. In 3296 it only was broken. :(

Tom

0
Comment actions Permalink

When pressing , IDEA inserts a blank line, then goes to the start of the line after the blank it inserted, very frustrating indeed.

0
Comment actions Permalink

Time to reopen IDEADEV-979

0
Comment actions Permalink

"Thomas Singer (MoTJ)" <I@HateSpam.de> wrote in message
news:d4oosh$n69$1@is.intellij.net...
>I agree, typing code is seriously broken in 3311. In 3296 it only was
>broken. :(
>

This build is DOA - I cannot edit code without the caret jumping all over
the place and random characters getting inserted.


--
Jordan Zimmerman
Senior Software Architect
Altura International
http://www.shop.com


0
Comment actions Permalink

I picture someone at JetBrains pressing a big red build-and-ship button....

Jordan Zimmerman wrote:

"Thomas Singer (MoTJ)" <I@HateSpam.de> wrote in message
news:d4oosh$n69$1@is.intellij.net...

>>I agree, typing code is seriously broken in 3311. In 3296 it only was
>>broken. :(
>>


This build is DOA - I cannot edit code without the caret jumping all over
the place and random characters getting inserted.

0
Comment actions Permalink

You mean a big red stop-ship button;)

Michael Besosa wrote:

I picture someone at JetBrains pressing a big red build-and-ship button....

Jordan Zimmerman wrote:

>> "Thomas Singer (MoTJ)" <I@HateSpam.de> wrote in message
>> news:d4oosh$n69$1@is.intellij.net...
>>
>>> I agree, typing code is seriously broken in 3311. In 3296 it only was
>>> broken. :(
>>>
>>
>>
>> This build is DOA - I cannot edit code without the caret jumping all
>> over the place and random characters getting inserted.
>>
>>

0
Comment actions Permalink

I just recalled a cartoon of late-Soviet era, when it became allowed to talk about stuff. Glasnost, perestroika, you know. The cartoon was about routine days of ballistic missile launch location. Once in a while they were having test launches. Using a big red button of course. So, once the button broke and they called for service. I guy came in, popped out the button, oiled it, put back and tried couple of times, how it works. Cut: launch location cover opens, nuclear ballistic missiles are fired: shoosh! shoosh! Cut: somewhere on the other side of the planet: boom! boom! Repair guy reports to the personnel: button works! They want to test it too. Press / fire / boom! Press / fire / boom! They are glad, button works. Vodka, drinking, russian nuclear arsenal is under control. The big general comes in: "What is happening? I was told that red button does not work?" Major to general: "Sir! It was repaired! Look:" Press / fire / boom! Press / fire / boom! It was a hilarious in its darkness; an apocaliptic cartoon. It then was getting better with radioactive mutants, nuclear winter and such. If you old enough to remember "Mad Max" movie, or "To Have and to Hold" by Depeche Mode, you know what am I talking about. "Michael Besosa" ]]> wrote in message
news:d4p4rp$dbj$1@is.intellij.net...

I picture someone at JetBrains pressing a big red

build-and-ship button....
>

Jordan Zimmerman wrote:

"Thomas Singer (MoTJ)" <I@HateSpam.de> wrote in message
news:d4oosh$n69$1@is.intellij.net...

>
>>I agree, typing code is seriously broken in 3311. In

3296 it only was

>>broken. :(
>>
>
>

This build is DOA - I cannot edit code without the caret

jumping all over

the place and random characters getting inserted.

>
>



0
Comment actions Permalink

ROFL... so you're saying that someone complained formatting didn't work,
and they tried to fix it, and now it's all gone to a dark hell with
major side effects which are causing everyone serious growth of warts
and skin defects because of the stress the formatter is causing. :)

I guess I am the guy on the other side of the world on the receiving end
of the boom with the subversion plugin :D (JetBrains I'M KIDDING!)

R

0
Comment actions Permalink

Robert S. Sfeir wrote:

I guess I am the guy on the other side of the world on the receiving end
of the boom with the subversion plugin :D (JetBrains I'M KIDDING!)


I hate to ask - wheres your George Bush?

"Mr President - we DONT HAVE WEAPONS OF MASS DESTRUCTION..."

"proove it!"

"...anymore."

"pardon?"

BOOM

0
Comment actions Permalink

I know it different:

Interviewer: "From what you know, that Iraque has weapons of mass-destruction?"

Mr. G. W. B. "We have the invoices."

0
Comment actions Permalink

"To Have and to Hold" by Depeche Mode


You area a DeMo fan? Welcome, friend! :D

Tom

0
Comment actions Permalink

"To Have and to Hold" by Depeche Mode


You area a DeMo fan? Welcome, friend! :D


And I thought I was the only one in the world anxiously waiting for the new album!

0

Please sign in to leave a comment.