"Suppress" and "Edit intention options" clutter the intention popup

I think the "Suppress xxx for statement" "Suppress xxx for method" "Edit
xxx options" items in the intention menu need to be rethought. They take
up too much space, because each one takes up one item in the typically small
intention list.

I have a few ideas for where they should go, but I don't like the ideas very
much. Maybe they will inspire someone else to come up with something better.

1. Each intention action has some icons next to it. In the case that the
inspection can be suppressed for a statement and for a method, there are
two red "X" icons to the right of the intention item, one for "Suppress for
statement" and one for "Suppress for method." When the user clicks one, the
corresponding suppress action is execute. Next to those is an "Options" icon,
which, when clicked, shows the options for that inspection.

One problem with that is I don't know how those mini icons would be navigated
from the keyboard. Maybe with Tab, maybe by pressing Alt+Enter again.

2. A separate action is provided for suppressing and configuring inspections
at the cursor. It would bring up an Alt+Enter-style popup, but it would only
contain the suppress and configure items. Maybe pressing Alt+Enter twice
would do this, or maybe AltShiftEnter.


If anyone has better ideas for how to move the suppress and configure actions,
please post them here. When I feel that we have a good idea, I'll post a
tracker issue.


21 comments
Comment actions Permalink

Keith Lea wrote:

I think the "Suppress xxx for statement" "Suppress xxx for method" "Edit xxx options" items in the intention menu need to be rethought. They take up too much space, because each one takes up one item in the typically small intention list.


Yes, these bug me as well.

1. Each intention action has some icons next to it. In the case that the
inspection can be suppressed for a statement and for a method, there are
two red "X" icons to the right of the intention item, one for "Suppress
for statement" and one for "Suppress for method." When the user clicks
one, the corresponding suppress action is execute. Next to those is an
"Options" icon, which, when clicked, shows the options for that inspection.

One problem with that is I don't know how those mini icons would be
navigated from the keyboard. Maybe with Tab, maybe by pressing Alt+Enter
again.


How about letter keys?

S - Suppress for statement
M - Suppress for method
O - Options

Ciao,
Gordon

--
Gordon Tyler (Software Developer)
Quest Software <http://www.quest.com/>
260 King Street East, Toronto, Ontario M5A 4L5, Canada
Voice: (416) 933-5046 | Fax: (416) 933-5001

0
Comment actions Permalink

Keith Lea wrote:

>> One problem with that is I don't know how those mini icons would be
>> navigated from the keyboard. Maybe with Tab, maybe by pressing
>> Alt+Enter again.
>>

How about letter keys?

S - Suppress for statement
M - Suppress for method
O - Options


This might work but you'd need more than those 3, because I think there are
also things like "Suppress for variable 'x'" and "Suppress for field 'x'"
and probably others.


0
Comment actions Permalink

Bugs me as well.

My suggestion would be having single item for supressions called 'Supress'
which would in turn show up little popup with three alternatives method,
class, statement.

Now if we only could move 'edit options' there as well. I see no common name
for those actions unfortunately.

-


Maxim Shafirov
http://www.jetbrains.com
"Develop with pleasure!"


0
Comment actions Permalink

Maxim

Bugs me as well.
My suggestion would be ..



Why not simply enable "Delete" (=> suppress) and "F4" (=> edit) in the
popup menu?


Alain

0
Comment actions Permalink

Maxim Shafirov (JetBrains) wrote:

Now if we only could move 'edit options' there as well. I see no common
name for those actions unfortunately.


What about "More..." or just "Options..."?

Sascha

0
Comment actions Permalink

I'm not sure I caught this, sorry?
-


Maxim Shafirov
http://www.jetbrains.com
"Develop with pleasure!"

Maxim

>> Bugs me as well.
>> My suggestion would be ..

Why not simply enable "Delete" (=> suppress) and "F4" (=> edit) in the
popup menu?

Alain



0
Comment actions Permalink

"Options" sounds good.

It's two different meanings of the "options" word though:
1. How can I configure this beast?
2. So what? What can I do? What options do I have?

Doesn't it look like a punster?

-


Maxim Shafirov
http://www.jetbrains.com
"Develop with pleasure!"

Maxim Shafirov (JetBrains) wrote:

>> Now if we only could move 'edit options' there as well. I see no
>> common name for those actions unfortunately.
>>

What about "More..." or just "Options..."?

Sascha



0
Comment actions Permalink

Maxim

I'm not sure I caught this, sorry?



Take 2:

Example:

int i;
=>]]> popup menu contains 4 entries, 1 is an intention XXXX, the other 3
are intention configurators: 2 are "Suppress ..", and the last one is
"Edit .. XXXX"

I'm suggesting you only show the intention.
With the popup menu open, and the focus on the intention to suppress, or
edit:
=> triggers "Suppress XXXX" (if there is more than one, display
the choice list.
=> triggers "Edit .. XXX"

Right-click on the intention would display the 3 configurators (suppress
+ edit).

Alain

0
Comment actions Permalink

In article <d494ta$iqq$1@is.intellij.net>,
Alain Ravet <alain.ravet@biz.tiscali.be> wrote:

Maxim

Bugs me as well.
My suggestion would be ..


Why not simply enable "Delete" (=> suppress) and "F4" (=> edit) in the
popup menu?


Too obscure, I would think of hitting delete to suppress or F4 to edit.

R

0
Comment actions Permalink

That wouldn't obvious to discover IMO...

-


Maxim Shafirov
http://www.jetbrains.com
"Develop with pleasure!"

Maxim

>> I'm not sure I caught this, sorry?
>>

Take 2:

Example:

int i;
<cursor here>
=> popup menu contains 4 entries, 1 is an intention XXXX, the other 3
are intention configurators: 2 are "Suppress ..", and the last one is
"Edit .. XXXX"

I'm suggesting you only show the intention.
With the popup menu open, and the focus on the intention to suppress,
or
edit:
=> triggers "Suppress XXXX" (if there is more than one, display
the choice list.
=> triggers "Edit .. XXX"
Right-click on the intention would display the 3 configurators
(suppress + edit).

Alain



0
Comment actions Permalink

Maxim Shafirov (JetBrains) wrote:

My suggestion would be having single item for supressions called
'Supress' which would in turn show up little popup with three
alternatives method, class, statement.

Now if we only could move 'edit options' there as well. I see no common
name for those actions unfortunately.


How about calling it something like "Edit or suppress...", for example?

/Kreiger



Attachment(s):
signature.asc
0
Comment actions Permalink

Another way would be to :

1/ in the popup menu, display only the intentions

if the user selects an intention and wait a few seconds (== doesn't
trigger it),
=> _1: auto-popup another menu, with the suppress and edit actions,
or
=> _2: add the relevant suppress and edit actions at the bottom of
the current popup.


I prefer _2.

Alain

0
Comment actions Permalink

I like "Options" too. One options entry even if multiple inspections are
triggered would be great.

Example 2 inspections trigger on a field:

@ Make initialization explicit
@ Suppres 'Instance variable may not be initialized' for field
@ Edit "Instance variable may not be initialized" inspection profile setting
@ Suppress 'Field accessed in both synchronized and unsynchronized
contexts' for field
@ Edit "Field accessed in both synchronized and unsynchronized contexts"
inspection profile setting

Would become:
@ Make initialization explicit
@ Options

Or maybe:
@ Make initialization explicit
@ Options (for 2 inspections)

Much less crowded. And I interpret Options as meaning 2: I have the
option of editing the inspection settings.

Bas

Maxim Shafirov (JetBrains) wrote:

"Options" sounds good.

It's two different meanings of the "options" word though:
1. How can I configure this beast?
2. So what? What can I do? What options do I have?

Doesn't it look like a punster?

-------------------
Maxim Shafirov
http://www.jetbrains.com
"Develop with pleasure!"

>> Maxim Shafirov (JetBrains) wrote:
>>
>>> Now if we only could move 'edit options' there as well. I see no
>>> common name for those actions unfortunately.
>>>
>> What about "More..." or just "Options..."?
>>
>> Sascha
>>


0
Comment actions Permalink

How about having separate check boxes for the suppress options and a button for the edit action at the bottom of the popup?
(Like the "include on-project classes" in the "go to class" popup, but at the bottom.)

I would propose to also show inspection warnings for suppressed inspections in the popup, so that I can use the checkbox to remove the suppression.

Reduces entry count, easy to discover, mnemonics are shown the standard way, and I can even remove suppresions with a shortcut this way.

0
Comment actions Permalink

Maxim Shafirov (JetBrains) wrote:

That wouldn't obvious to discover IMO...


Possibly, you could display instructions in the status bar...

But yeah, it's kinda hidden.

Ciao,
Gordon

--
Gordon Tyler (Software Developer)
Quest Software <http://www.quest.com/>
260 King Street East, Toronto, Ontario M5A 4L5, Canada
Voice: (416) 933-5046 | Fax: (416) 933-5001

0
Comment actions Permalink

In article <robert-D235BA.18111221042005@mail.intellij.net>,
"Robert S. Sfeir" <robert@codepuccinoNOSPAM.com> wrote:

In article <d494ta$iqq$1@is.intellij.net>,
Alain Ravet <alain.ravet@biz.tiscali.be> wrote:

Maxim

Bugs me as well.
My suggestion would be ..


Why not simply enable "Delete" (=> suppress) and "F4" (=> edit) in the
popup menu?


Too obscure, I would think of hitting delete to suppress or F4 to edit.


I actually like it as it is, but perhaps with different shortcut keys.

Scott

0
Comment actions Permalink

Microsoft and Adobe use toolbar buttons with option's menus attached to them. Perhaps the intention button could have a little options half-button that would display the suppress and edit options. See pics. samp1.png is the font color button in the Microsoft Word. Clicking on the center of the button changes to the font color to the current default, clicking on the right half of the button brings up the a color palette.

samp2.png is a photoshopped example of what it might look like with intentions.



Attachment(s):
samp1.png
samp2.png
0
Comment actions Permalink

I like this idea. I think the UI is clear and concise.

Microsoft and Adobe use toolbar buttons with option's menus attached
to them. Perhaps the intention button could have a little options
half-button that would display the suppress and edit options. See
pics. samp1.png is the font color button in the Microsoft Word.
Clicking on the center of the button changes to the font color to the
current default, clicking on the right half of the button brings up
the a color palette.

samp2.png is a photoshopped example of what it might look like with
intentions.




0
Comment actions Permalink

Yep, that's it.

-


Maxim Shafirov
http://www.jetbrains.com
"Develop with pleasure!"

I like this idea. I think the UI is clear and concise.

>> Microsoft and Adobe use toolbar buttons with option's menus attached
>> to them. Perhaps the intention button could have a little options
>> half-button that would display the suppress and edit options. See
>> pics. samp1.png is the font color button in the Microsoft Word.
>> Clicking on the center of the button changes to the font color to the
>> current default, clicking on the right half of the button brings up
>> the a color palette.
>>
>> samp2.png is a photoshopped example of what it might look like with
>> intentions.
>>


0
Comment actions Permalink

Use an extra Alt+Enter as keyboard short cut? And make it little
prettier please.

Bas

Maxim Shafirov (JetBrains) wrote:

Yep, that's it.

-------------------
Maxim Shafirov
http://www.jetbrains.com
"Develop with pleasure!"

>>I like this idea. I think the UI is clear and concise.
>>
>>
>>>Microsoft and Adobe use toolbar buttons with option's menus attached
>>>to them. Perhaps the intention button could have a little options
>>>half-button that would display the suppress and edit options. See
>>>pics. samp1.png is the font color button in the Microsoft Word.
>>>Clicking on the center of the button changes to the font color to the
>>>current default, clicking on the right half of the button brings up
>>>the a color palette.
>>>
>>>samp2.png is a photoshopped example of what it might look like with
>>>intentions.
>>>


0
Comment actions Permalink

Yup, that's nice, will take a little getting used to but it's great.
Would be good if Jetbrains carried this idea across most of it's menus
and buttons so people know that's a normal behavior. In other words
don't stick this feature in one place :)

R

0

Please sign in to leave a comment.