Formatting - much much better, but....

The formatting in 3229 is much much better, in particular the continuation indent bug seems to be fixed. But it does some extremely wierd things to long expressions like:


I haven't got enough space here to reproduce what it does to this expression. It seems to align each line with the || symbol of the previous line, and occasionally even further out.

Still, I'm happy!

4 comments
Comment actions Permalink

Yes, it also reformats method declarations so that they look like this:

Which I think is ugly and wasteful and I believe goes against the Java Coding Conventions document from Sun. Anyway, I can't find a way to turn this off.

0
Comment actions Permalink

Well, this formatting style used to be an option (align method parameters). Problem is, it's being applied by default now.

0
Comment actions Permalink

What makes me ask a hint from JetBrains... we know the code formatter is currently being rewritten and it's under heavy work. How much do you want us to fill bug reports? I've filled some on JIRA, but there are so many small issues that makes me ponder if it's really worth reporting all of them, instead of just waiting for the new reformatter to get more solid.

I could fill one single issue that reads like that: "Code Reformatter should work as it did in Pallada", and that would cover over 10 small issues I've found out already.

0
Comment actions Permalink

Filling issues worth it indeed. Every issue you report against formatter
would turn into regression testcase as well. As the matter of fact there
are just so many combinations to check formatter against.
Filling "make it work as it did in Pallada" worth nothing 'cause the only
way we could fix that is throw away new code and use old one, right?
-


Maxim Shafirov
http://www.jetbrains.com
"Develop with pleasure!"

What makes me ask a hint from JetBrains... we know the code formatter
is currently being rewritten and it's under heavy work. How much do
you want us to fill bug reports? I've filled some on JIRA, but there
are so many small issues that makes me ponder if it's really worth
reporting all of them, instead of just waiting for the new reformatter
to get more solid.

I could fill one single issue that reads like that: "Code Reformatter
should work as it did in Pallada", and that would cover over 10 small
issues I've found out already.




0

Please sign in to leave a comment.