Variable suggestions

Did the variable name suggestion algorithm change recently? I don't remember
seeing a note about it. Variable name suggestions were getting excellent for
me - it matched my style perfectly (Unix/K&R). In the latest release, it's
switched to always JDK style.

--
Jordan Zimmerman
http://www.jordanzimmerman.com


11 comments

What are Unix/K&R and JDK style? I haven't noticed a difference

0

Could it be that IDEA isn't using your code style anymore? It deleted mine a few days ago and I had to copy it from saved settings.

0

Jordan,

please see http://www.intellij.net/tracker/idea/viewSCR?publicId=7677
Is that what troubles you?

Friendly,
Dmitry

Jordan Zimmerman wrote:

Did the variable name suggestion algorithm change recently? I don't
remember seeing a note about it. Variable name suggestions were getting
excellent for me - it matched my style perfectly (Unix/K&R). In the latest
release, it's switched to always JDK style.


--
Dmitry Lomov
IntelliJ Labs / JetBrains Inc.
http://www.intellij.com
"Develop with pleasure!"

0

"Dmitry Lomov (JetBrains)" <Dmitry.Lomov@jetbrains.com> wrote in message
news:bno759$ab0$1@is.intellij.net...

Jordan,

>

please see http://www.intellij.net/tracker/idea/viewSCR?publicId=7677
Is that what troubles you?


Yes, that's it. This "fix" messed me up. Is there any way to turn this off?

--
Jordan Zimmerman
http://www.jordanzimmerman.com


0

>"Keith Lea" <keith@cs.oswego.edu> wrote in message
news:1616413.1067387864772.JavaMail.itn@is.intellij.net...

What are Unix/K&R and JDK style? I haven't noticed a difference


Unix/K&R style:

this_is_a_variable_name

JDK style:

thisIsAVariableName

--
Jordan Zimmerman
http://www.jordanzimmerman.com


0

Jordan Zimmerman wrote:

"Dmitry Lomov (JetBrains)" <Dmitry.Lomov@jetbrains.com> wrote in message
news:bno759$ab0$1@is.intellij.net...

>> Jordan,
>>
>> please see http://www.intellij.net/tracker/idea/viewSCR?publicId=7677
>> Is that what troubles you?


Yes, that's it. This "fix" messed me up. Is there any way to turn this
off?


Well, you actually have a suggestion with the original name in the list.
Is that not acceptable for you?

What do others think?

Friendly,
Dmitry

--
Dmitry Lomov
IntelliJ Labs / JetBrains Inc.
http://www.intellij.com
"Develop with pleasure!"

0

"Dmitry Lomov (JetBrains)" <Dmitry.Lomov@jetbrains.com> wrote in message
news:bnovc1$th0$1@is.intellij.net...
>

Well, you actually have a suggestion with the original name in the list.
Is that not acceptable for you?


No, it's not the original name. Try this. Given the following line of code:

int my_k_r_var;

Click on the variable name and select "Rename" from the Refactor menu. The
variable name in the dialog will be:

myKRVar

Whereas before, it would stay as it was originally

my_k_r_var

--
Jordan Zimmerman
http://www.jordanzimmerman.com


0

I was the initiator of SCR7677 and the reason I posted it was that I was really pissed off by some of my predecessors who did not stick to Sun's recommended naming conventions, making the code absolutely unreadable. I really like the new default renaming suggestion, because it helps me a lot in cleaning the crap code up.

0

"Sergei S. Ivanov" <no_mail@jetbrains.com> wrote in message
news:20831240.1067520698792.JavaMail.javamailuser@localhost...

I was the initiator of SCR7677 and the reason I posted it was that I was

really pissed off by some of my predecessors who

did not stick to Sun's recommended naming conventions, making the code

absolutely unreadable. I really like the new default

renaming suggestion, because it helps me a lot in cleaning the crap code

up.

It's fine with me as long as IntelliJ adds an option to turn it off. I've
lost productivity due to this change.

--
Jordan Zimmerman
http://www.jordanzimmerman.com


0

Then, probably, enter a feature request for an additional option: "always pre-select the original name while renaming".

0

Jordan Zimmerman wrote:

"Sergei S. Ivanov" <no_mail@jetbrains.com> wrote in message
news:20831240.1067520698792.JavaMail.javamailuser@localhost...

>> I was the initiator of SCR7677 and the reason I posted it was that I was

really pissed off by some of my predecessors who

>> did not stick to Sun's recommended naming conventions, making the code

absolutely unreadable. I really like the new default

>> renaming suggestion, because it helps me a lot in cleaning the crap code

up.

It's fine with me as long as IntelliJ adds an option to turn it off. I've
lost productivity due to this change.


Jordan,
please file an SCR for this option. We can then discuss what to do there.

Friendly,
Dmitry

--
Dmitry Lomov
IntelliJ Labs / JetBrains Inc.
http://www.intellij.com
"Develop with pleasure!"

0

Please sign in to leave a comment.