inspect code command: why on the editor context menu ?

IMO having the inspect code command on the editor context menu is just
cluttering it.

when run, it asks whether it should be run on a file or on the whole roject.
therefore it would find better location on context menus for items
representing the file (eg tabs, nodes in the project tree) rather than
the editor where one expects commands to apply to selected parts of the
code.

Edo

8 comments
Comment actions Permalink

But how should I quickly inspect code in the current file? I wouldn't want
to be forced to select it in the Project view.

--
Valentin Kipiatkov
JetBrains, Inc
http://www.intellij.com
"Develop with pleasure!"

"Edoardo Comar" <e.comar.no.spam@no.spam.btinternet.com> wrote in message
news:bleoh2$evn$1@is.intellij.net...

IMO having the inspect code command on the editor context menu is just
cluttering it.

>

when run, it asks whether it should be run on a file or on the whole

roject.

therefore it would find better location on context menus for items
representing the file (eg tabs, nodes in the project tree) rather than
the editor where one expects commands to apply to selected parts of the
code.

>

Edo

>


0
Comment actions Permalink

Valentin Kipiatkov (JetBrains) wrote:

But how should I quickly inspect code in the current file? I wouldn't want
to be forced to select it in the Project view.

ctx menu from the tab ?

0
Comment actions Permalink

Edoardo Comar wrote:

Valentin Kipiatkov (JetBrains) wrote:

>> But how should I quickly inspect code in the current file? I wouldn't
>> want
>> to be forced to select it in the Project view.
>>

ctx menu from the tab ?

I see my objection was not too correct.
there are many actions in the editor ctx menu that are not specific to a
portion of the file but to the file in its entirety, eg the VCS commands

maybe the inspect code command from the editor context menu should
always be - inspect code for THIS file
while the inspect code for a set of files (up to the full project)
should be left as a command on the menubar or project tree

Edo

0
Comment actions Permalink

maybe the inspect code command from the editor context menu should
always be - inspect code for THIS file
while the inspect code for a set of files (up to the full project)
should be left as a command on the menubar or project tree


Does it mean that "Inspect Code" from the editor's popup menu should always
inspect code from the file while Tools | Inspect Code from the main menu
(when focus is in the editor) should ask?

--
Valentin Kipiatkov
JetBrains, Inc
http://www.intellij.com
"Develop with pleasure!"


"Edoardo Comar" <e.comar.no.spam@no.spam.btinternet.com> wrote in message
news:blet60$h92$2@is.intellij.net...

Edoardo Comar wrote:

>

Valentin Kipiatkov (JetBrains) wrote:

>
>> But how should I quickly inspect code in the current file? I wouldn't
>> want
>> to be forced to select it in the Project view.
>>

ctx menu from the tab ?

>
I see my objection was not too correct.
there are many actions in the editor ctx menu that are not specific to a
portion of the file but to the file in its entirety, eg the VCS commands

>

maybe the inspect code command from the editor context menu should
always be - inspect code for THIS file
while the inspect code for a set of files (up to the full project)
should be left as a command on the menubar or project tree

>

Edo

>


0
Comment actions Permalink

Valentin Kipiatkov (JetBrains) wrote:
>>maybe the inspect code command from the editor context menu should
>>always be - inspect code for THIS file
>>while the inspect code for a set of files (up to the full project)
>>should be left as a command on the menubar or project tree


Does it mean that "Inspect Code" from the editor's popup menu should always
inspect code from the file while Tools | Inspect Code from the main menu
(when focus is in the editor) should ask?

I think so.
IMO a global (eg project-wide) action should not be invoked from the
editor context menu.

Edo

0
Comment actions Permalink

Edoardo Comar wrote:

IMO a global (eg project-wide) action should not be invoked from the
editor context menu.


I disagree. I use the CVS > Update Project and CVS > Commit Project from the
context menu extremely often. They don't seem out of place there IMO & you
know that what you're doing effects the entire project because it says so in
the name.

Your specific point, that invoking Inspect Code from the context menu should
just operate on the current file, I do agree with. I just don't think you
can generalise it to cover all actions.

Vil.
--
Vilya Harvey
vilya.harvey@digitalsteps.com / digital steps /
(W) +44 (0)1483 469 480
(M) +44 (0)7816 678 457 http://www.digitalsteps.com/

Disclaimer

This e-mail and any attachments may be confidential and/or legally
privileged. If you have received this email and you are not a named
addressee, please inform the sender at Digital Steps Ltd by phone on
+44 (0)1483 469 480 or by reply email and then delete the email from
your system. If you are not a named addressee you must not use,
disclose, distribute, copy, print or rely on this email. Although
Digital Steps Ltd routinely screens for viruses, addressees should
check this email and any attachments for viruses. Digital Steps Ltd
makes no representation or warranty as to the absence of viruses in this
email or any attachments.

0
Comment actions Permalink

In fact both main menu item and popup menu item represent the same action.
So the behaviour is the same. We can write some code to change behaviour of
an action when it's invoked in particular way (e.g. from popup menu). But is
it a good idea? What if I assign a shortcut for this action?

--
Valentin Kipiatkov
JetBrains, Inc
http://www.intellij.com
"Develop with pleasure!"

"Edoardo Comar" <e.comar.no.spam@no.spam.btinternet.com> wrote in message
news:blev0h$cfi$1@is.intellij.net...

Valentin Kipiatkov (JetBrains) wrote:
>>maybe the inspect code command from the editor context menu should
>>always be - inspect code for THIS file
>>while the inspect code for a set of files (up to the full project)
>>should be left as a command on the menubar or project tree
>
>

Does it mean that "Inspect Code" from the editor's popup menu should

always

inspect code from the file while Tools | Inspect Code from the main menu
(when focus is in the editor) should ask?

>
I think so.
IMO a global (eg project-wide) action should not be invoked from the
editor context menu.

>

Edo

>


0
Comment actions Permalink

Maybe then they should be split into 2 separate actions...

N.

Valentin Kipiatkov (JetBrains) wrote:

In fact both main menu item and popup menu item represent the same action.
So the behaviour is the same. We can write some code to change behaviour of
an action when it's invoked in particular way (e.g. from popup menu). But is
it a good idea? What if I assign a shortcut for this action?


0

Please sign in to leave a comment.