#833: cvs commit automatically adds all unknown files

When using CTRL + K to commit all changes in a project to CVS, the
unknown files not explicitly removed from commit are all added to CVS
during checkin. Is this a bug, should I file a report? Or is it intended
behaviour? In this case I think it is a bad feature. I just accidently
added lots of files.

Michael

16 comments
Comment actions Permalink

On Thu, 19 Jun 2003 23:29:30 +0200, Michael Descher wrote:

When using CTRL + K to commit all changes in a project to CVS, the unknown
files not explicitly removed from commit are all added to CVS during
checkin. Is this a bug, should I file a report? Or is it intended
behaviour? In this case I think it is a bad feature. I just accidently
added lots of files.


I didn't see this today and I was committing all over the place, the first
time I manually removed the unknowns from the commit, then I forgot, and
they skipped, so just kept going on :)


--
...turn to the light - don't be frightened by the shadows it creates,
...turn to the light - turning away could be a terrible mistake
...dream theater - the great debate


0
Comment actions Permalink

Are your unkown files in not checked in directories only? Maybe they only get added in case they are in directories that are under CVS control. I will check if this is the case but I was able to reproduce that behaviour yesterday. Didn't try again so far. ;)

Michael

0
Comment actions Permalink

I just checked it again. I created a new cvs project called "test" with a single file "test.txt" in it. Then I created an IDEA project for it, added two folders and one file in each folder. CVS integration was switched off, so nothing was added. I turned CVS on and did CTRL + K. The dialog popped up with the to folders, the files in the folders and the three project files (ipr, iml, iws) marked as unknown. I clicked "ok" and after that ALL those files and directories were in CVS!

0
Comment actions Permalink

On Fri, 20 Jun 2003 10:23:45 +0000, Michael Descher wrote:

Are your unkown files in not checked in directories only? Maybe they only
get added in case they are in directories that are under CVS control. I
will check if this is the case but I was able to reproduce that behaviour
yesterday. Didn't try again so far. ;)


From memory they were non cvs directories ( jsp compiled files and .class
files ).

--
...turn to the light - don't be frightened by the shadows it creates,
...turn to the light - turning away could be a terrible mistake
...dream theater - the great debate


0
Comment actions Permalink

On Fri, 20 Jun 2003 10:30:35 +0000, Michael Descher wrote:

I just checked it again. I created a new cvs project called "test" with a
single file "test.txt" in it. Then I created an IDEA project for it, added
two folders and one file in each folder. CVS integration was switched off,
so nothing was added. I turned CVS on and did CTRL + K. The dialog popped
up with the to folders, the files in the folders and the three project
files (ipr, iml, iws) marked as unknown. I clicked "ok" and after that ALL
those files and directories were in CVS!


Hmm, Windows, Linux, or MacOS?

--
...turn to the light - don't be frightened by the shadows it creates,
...turn to the light - turning away could be a terrible mistake
...dream theater - the great debate


0
Comment actions Permalink

windows xp as well as windows 2000.

0
Comment actions Permalink

Unknown files will be added and commited to the cvs if they aren't excluded
from checkin.
You can also ignore these files or whole directory using "Ignore" action.

--
Best regards,
Olesya Smirnova
JetBrains, Inc / IntelliJ Software
http://www.intellij.com
"Develop with pleasure!"


"Michael Descher" <michael.descher@gmx.de> wrote in message
news:bct9vn$cdm$1@is.intellij.net...

When using CTRL + K to commit all changes in a project to CVS, the
unknown files not explicitly removed from commit are all added to CVS
during checkin. Is this a bug, should I file a report? Or is it intended
behaviour? In this case I think it is a bad feature. I just accidently
added lots of files.

>

Michael

>


0
Comment actions Permalink

Probably, Aurora can have an option to specify that by default whether unknown files will be added and committed.

I wouldn't like current default behaviour either. :(

0
Comment actions Permalink

Added a feature request:
http://www.intellij.net/tracker/idea/viewSCR?publicId=13561

You may vote for it if you like.


simplicity wrote:

Probably, Aurora can have an option to specify that by default whether unknown files will be added and committed.

I wouldn't like current default behaviour either. :(


0
Comment actions Permalink

Olesya Smirnova wrote:

Unknown files will be added and commited to the cvs if they aren't excluded
from checkin.
You can also ignore these files or whole directory using "Ignore" action.


Sorry, but I cannot find an "Ignore" action in 833.
Where should it be?

Christoph

0
Comment actions Permalink

On Fri, 20 Jun 2003 12:49:28 +0000, Michael Descher wrote:

windows xp as well as windows 2000.


Mmm linux here on both machines. mmm.

--
...turn to the light - don't be frightened by the shadows it creates,
...turn to the light - turning away could be a terrible mistake
...dream theater - the great debate


0
Comment actions Permalink

Similarly, I find it a horror when deleting files will automatically trigger "cvs remove".

This is dangerous! :((

0
Comment actions Permalink

Yes, CVS-add and CVS-remove should always be manually triggered actions.
Optionally adding/removing them when adding files in IDEA or deleting
files from IDEA (the dialog box asking whether the file should be added
to or removed from CVS as well) is fine. But assuming that the user
always wants an exact copy of his local files in CVS is really dangerous.

Michael

simplicity wrote:

Similarly, I find it a horror when deleting files will automatically trigger "cvs remove".

This is dangerous! :((


0
Comment actions Permalink

Michael Descher wrote:

Yes, CVS-add and CVS-remove should always be manually triggered actions.
Optionally adding/removing them when adding files in IDEA or deleting
files from IDEA (the dialog box asking whether the file should be added
to or removed from CVS as well) is fine. But assuming that the user
always wants an exact copy of his local files in CVS is really dangerous.


Michael,
CVS add/remove operates on local files. Nothing gets added/removed on
server until you say commit. add/remove is a way to notify CVS of the
things you do, so that e.g. update work correctly. On the contrary, if you
do not do add/remove after operating on local files, you are in big trouble
;)

Friendly,
Dmitry


Michael

simplicity wrote:

>> Similarly, I find it a horror when deleting files will automatically
>> trigger "cvs remove".
>>
>> This is dangerous! :((

--
Dmitry Lomov
IntelliJ Labs / JetBrains Inc.
http://www.intellij.com
"Develop with pleasure!"

0
Comment actions Permalink

Well, the problem is not CVS-add/remove but adding files in IDEA, NOT
doing CVS-add since I want the files on my local drive only or files
being created during the build process (e.g. lots of generated temporary
stuff) and then committing through IDEA adds all those files to CVS
(i.e. they are on the server after committing). I don't want IDEA to add
any files to the CVS server unless I explicitly tell it to do so with a
CVS-add command. This was working perfectly until build 833 came out. I
really don't understand why the new feature of automatically adding all
files not explicitly ignored to the CVS server was implemented.

Michael

Dmitry Lomov wrote:

Michael Descher wrote:

>>Yes, CVS-add and CVS-remove should always be manually triggered actions.
>>Optionally adding/removing them when adding files in IDEA or deleting
>>files from IDEA (the dialog box asking whether the file should be added
>>to or removed from CVS as well) is fine. But assuming that the user
>>always wants an exact copy of his local files in CVS is really dangerous.


Michael,
CVS add/remove operates on local files. Nothing gets added/removed on
server until you say commit. add/remove is a way to notify CVS of the
things you do, so that e.g. update work correctly. On the contrary, if you
do not do add/remove after operating on local files, you are in big trouble
;)

Friendly,
Dmitry

>>Michael
>>
>>simplicity wrote:
>>
>>
>>>Similarly, I find it a horror when deleting files will automatically
>>>trigger "cvs remove".
>>>
>>>This is dangerous! :((



0
Comment actions Permalink

What's the difference between excluding a file from the checkin and ignoring it? Will "ignore" add the file to .cvsignore so it CVS won't pick it up next time?

0

Please sign in to leave a comment.