File with inspection "infos": Should it be yellow or green?

I have set quite many inspections to show at "info" level (shown as "yellowish underwiggle" in the source).

Still the square at the top of the right gutter is yellow, even if my file contains no warnings, but just infos.

IMHO this should be changed, so that the file as a whole is indicated as "green".

The concept of inspections suffer a lot if you can't hold to the one premise
"Keep the code green"

If it's yellow anyway people won't care for one more or less warning in the code.

What do you think?

9 comments
Comment actions Permalink

What do you think?


I absolutely agree. IMHO the main reason for having an info level is to keep the file green without losing helpful information.

0
Comment actions Permalink

+10

This is something I've often wished for, but never got around to filing a bug for.

0
Comment actions Permalink

A solution might be to add some more features in the Severity Options

1) I've tested to disable the error-stripe mark on info, but then the (square top) file marking turned gray
--> imho when the error-stripe marking is disabled it shouldn't influence the file marking (and should thus be able to stay green when you only have info level inspection warnings)

2) However you might still want a white/yellowish error-stripe in the gutter, which would be a reason to add an option 'not influence the file marker' to the error-stripe setting in the Severity Options.

0
Comment actions Permalink

Yeah, you're right. A general solution would be to enhance the severity settings.
I propose to have an additional settings "File Indicator Color" (better name?) at each severity.
Then make the square show this configured color of the highest (according to the order in the severities editor dialog) present inspection result.

Maybe let's add comments to Jira rather than discuss here, so that it's all present in one place:
http://www.jetbrains.net/jira/browse/IDEA-13775

0
Comment actions Permalink

>I propose to have an additional settings "File Indicator Color" (better name?) at each severity.
sweet

Maybe let's add comments to Jira rather than discuss here, so that it's all present in one place:

Ok (as far as it still needs any now... :)

0
Comment actions Permalink

-10.

If the file is yellow, then it's yellow; I don't see any reason to pretend it's green.

If that is a problem for you, just change the color of the "INFO" level marks to green; then you will have little green gutter marks indicating an INFO issue and your file will be green. But I would consider this a deviation from the facts.

Regards,
Jens

BTW, is there a way to vote against a JIRA issue?

0
Comment actions Permalink

Jens,
> If the file is yellow, then it's yellow; I don't think there's any reason to pretend it's green.

1) if you want it yellow, leave the inspection level at "warning". There's no inspection that by
default has "info" level, anyway. My point is exactly that "warning == yellow" and the desire to have
another category.
2) With my current proposal you would be free to set the info color to anything you like.


Jens Voss wrote:

-10.


If that is a problem for you, just change the color of the "INFO" level marks to green; then you will have little green gutter marks indicating an INFO issue and your file will be green. But I would consider this a deviation from the facts.

Regards,
Jens

0
Comment actions Permalink

After all this was the main reason why we asked for an additional
severity level years ago: to have green files without losing interesting
information. IMHO a file should only turn into yellow if it contains
something bad which should be corrected. But there are lots of
inspections which point to interesting code which isn't bad at all, e.g.
'Call to System.setSecurityManager()'. There's absolutely nothing bad
about setting a security manager, but still I would like to have a
gutter mark where it is done.

Stephen Friedrich wrote:

Jens,
> If the file is yellow, then it's yellow; I don't think there's any
reason to pretend it's green.

1) if you want it yellow, leave the inspection level at "warning".
There's no inspection that by
default has "info" level, anyway. My point is exactly that "warning
== yellow" and the desire to have
another category.
2) With my current proposal you would be free to set the info color to
anything you like.


Jens Voss wrote:

>> -10.
>>
>>
>> If that is a problem for you, just change the color of the "INFO"
>> level marks to green; then you will have little green gutter marks
>> indicating an INFO issue and your file will be green. But I
>> would consider this a deviation from the facts.
>>
>> Regards,
>> Jens

--
Martin Fuhrer
Fuhrer Engineering AG
http://www.fuhrer.com

0

Please sign in to leave a comment.