problems with TreeClassChooserFactory dialogs

Hello,

Could you provide a minimal but complete sample project which illustrates the problem and your plugin with instructions on how to use it?

Denis

P.S. You can use this plugin for pasting colors-aware code into forum.

Hi,

I made a bug report on it with id IDEA-107991. http://youtrack.jetbrains.com/issue/IDEA-107991

I attached what you requested on that. Can you take a look and tell me what is wrong?

Thanks,
Teemu

Just checked your files and here is what I see:

1. It's expected to see classes which implement TransitionFilter interface there because TransitionFilter extends GenerationListener. That effectively makes every class which IS-A TransitionFilter also IS-A GenerationListener. You can provide custom ClassFilter into overloaded TreeClassChooserFactory.createInheritanceClassChooser() method and explicitly reject all classes which indirectly implement GenerationListener (that looks like a bad idea though);
2. When osmotester jar is detached, no match against GenerationListener is found, that's why list of all classes is displayed;

Denis

Hi

Thanks for taking a look. I see it was my bad for not checking the inheritance tree.

So I guess if you create the chooser with the inheritanceXXX factory method, it is not a real filter like it is if you attach one yourself (like in the "classes" tab)? I thought it should not show anything if nothing was there to show. Also, if I changed it to a Map interface it showed me a strange choice, which I still do not quite understand. Not that it matters as I do not really plan to look for Map implementations and I guess I can try to filter the unwanted inheritance tree by creating my own filter. The custom filtering seems slower but I guess I have to look into the indexing API or something. The stuff could be a bit better documented.

Again, thanks for the help.
Teemu

Hi

I still have a similar issue but with the end condition chooser in the same project and with the same plugin.

Click the "..." on the right of "Test endcondition". You get the right choices but there is also stuff like "And (com.sun.org.apache.xpath.internal.operations)". I do not know if this is because there is also "And (osmo.tester.generator.endcondition.logical)" which is and should be in the list.

So, can you tell me what did I do wrong with that one?

At least I can't see how the Apache code would inherit my custom class..

associated code:

    TreeClassChooserFactory factory = TreeClassChooserFactory.getInstance(project);
    final Module module = moduleSelector.getModule();
    GlobalSearchScope scope = null;
    if (module != null) {
      scope = GlobalSearchScope.moduleWithDependenciesAndLibrariesScope(module);
    } else {
      scope = GlobalSearchScope.allScope(project);
    }
    PsiClass ecClass = JavaPsiFacade.getInstance(project).findClass(EndCondition.class.getName(), scope);
    PsiClass current = JavaPsiFacade.getInstance(project).findClass(ecField.getText(), scope);

    TreeClassChooser chooser = factory.createInheritanceClassChooser(title, scope, ecClass, current);
    chooser.showDialog();

Teemu

I don't have any classes from com.sun.org.apache.xpath.internal.operations package there:


Btw, you can always debug the processing at local environment if the problem is stabily reproduced there.

Denis

OK, I guess you have somehow a different environment when you run it.

However, your screenshot shows two instances of EndCondition. osmo.tester.annotation.EndCondition and osmo.tester.generator.endcondition.EndCondition. So, if we use this as an example, the question is:

With the chooser code as follows:

import osmo.tester.generator.endcondition.EndCondition;

public class ECChoiceListener implements ActionListener {
....
    TreeClassChooserFactory factory = TreeClassChooserFactory.getInstance(project);
    GlobalSearchScope scope = GlobalSearchScope.allScope(project);
    PsiClass ecClass = JavaPsiFacade.getInstance(project).findClass(EndCondition.class.getName(), scope);
    PsiClass current = JavaPsiFacade.getInstance(project).findClass(ecField.getText(), scope);

    TreeClassChooser chooser = factory.createInheritanceClassChooser(title, scope, ecClass, current);
    chooser.showDialog();