Plugin broken: HighlightInfo changed from factory to builder pattern

Hi

Since latest 12.1 EAP, Build 126.330 my plugin is broken.

I'm using the class "com.intellij.codeInsight.daemon.impl.HighlightInfo".

With revision aee0f1dd533ffd34d6471811d23e6c96d566bfc9 this class changed from factory to builder pattern. All constructors are now package visible and the factory methods are not longer available. So it looks like the only way to create instances of HighlightInfo is using the builder. Of course this is not a problem, but for now I have create a new branch of my plugin and deploy a 12.1 compatible version (until now my plugin works since 11.0).

I'm sure there are more plugins using HighlightInfo and these all are probably broken by this one... or have I overlooked something...? Do we get the factory methods back?

Thanks for feedback
regards
Minas.

3 comments

Hello Minas,
I've restored old methods for the time being.
However, I marked them deprecated and I swear i'll removed them in IDEA 13.
The problem with the createXXX methods is that firstly there are zillion of them and sencondly, some of them accept escaped tooltip and some don't.
Some apply HighlightInfo filters and some don't.
Which caused all kinds of "weird   symbols in the tooltip" mess.
Please don't use them.

Alexey Kudravtsev
Intellij IDEA  developer
JetBrains, Inc
http://www.jetbrains.com
"Develop with  pleasure!"
0

>> Which caused all kinds of "weird   symbols in the tooltip" mess.

>> Which caused all kinds of "weird nbsp;nbsp;  symbols in the tooltip" mess.

See what I mean?

Alexey Kudravtsev
Intellij IDEA  developer
JetBrains, Inc
http://www.jetbrains.com
"Develop with  pleasure!"
0

Hello Alexey

I see. I think it's fine to deprecate in 12.1 and remove in 13. No problem.

Thank you.

Regards
Minas.
0

Please sign in to leave a comment.