ErrorReportSubmitter confirmation dialogs

I have implemented a sublclass of ErrorReportSubmitter and it is registered as an errorHandler in my plugin.xml. All works fine and the code that I've written for the error reporting is executed without any problems.

The submit() method that is defined in ErrorReportSubmitter and which I have implemented, returns a SubmittedReportInfo which contains information about the success or failure of the reporting and in case of a success also contains a URL which the user can use to jump to the generated report.
Now I expected IDEA would create a confirmation dialog which somehow interprets the returned SubmittedReportInfo and display a useful message.Unfortunately no such dialog is created. Only the Blame-button is disabled if the report was successful.

Do I have to create the confirmation dialogs myself or should IDEA have created them?
If IDEA should have created them: Any idea what the problem might be? There are no Exceptions or log output that would hint at it.

Cheers,
Robert

2 comments
Comment actions Permalink

Hello Robert,

You are not really supposed to subclass ErrorReportSubmitter, because it's
completely tied to our own exception reporting infrastructure. Some other
plugins (for example, the IDEA 7 version of the Ruby plugin) have implemented
their own error reporting solutions, which you can copy and use in your plugin.

I have implemented a sublclass of ErrorReportSubmitter and it is
registered as an errorHandler in my plugin.xml. All works fine and the
code that I've written for the error reporting is executed without any
problems.

The submit() method that is defined in ErrorReportSubmitter and which
I have implemented, returns a SubmittedReportInfo which contains
information about the success or failure of the reporting and in case
of a success also contains a URL which the user can use to jump to the
generated report.

Now I expected IDEA would create a confirmation dialog which somehow
interprets the returned SubmittedReportInfo and display a useful
message.Unfortunately no such dialog is created. Only the Blame-button
is disabled if the report was successful.

Do I have to create the confirmation dialogs myself or should IDEA
have created them? If IDEA should have created them: Any idea what the
problem might be? There are no Exceptions or log output that would
hint at it.

Cheers,
Robert

--
Dmitry Jemerov
Development Lead
JetBrains, Inc.
http://www.jetbrains.com/
"Develop with Pleasure!"


0
Comment actions Permalink

That's well surprising.
It took the Groovy plugin as a reference which also subclasses ErrorReportSubmitter for an error handler. And the javaDoc of ErrorReportSubmitter says:
This class should be extended by plugin vendor and provided by means of {@link com.intellij.ExtensionPoints#ERROR_HANDLER} if reporting errors that happened in plugin code to vendor is desirable.

So is this javaDoc incorrect or do we have some kind of misunderstanding here?

Anyways, a quick look at http://svn.jetbrains.org/idea/Trunk/ruby/src/org/jetbrains/plugins/ruby/error/RubyErrorReportSubmitter.java reveals that the Ruby plugin also subclasses this class.

Cheers,
Robert

0

Please sign in to leave a comment.