VCS Plugin reporting modifed files as added

This keeps hapening to me but I can't seem to reproduce it intentinaly. Has anybody else been seeing this.
I am using my AccuRev plugin and calling the default implementations for the change reporting provides


Has anybody else been seeing this?

19 comments
Comment actions Permalink

I did get that problem and didn't report as I can't reproduce it.

-Dash.

"Joey Edelstein" <no_mail@jetbrains.com> wrote in message
news:27800367.1062676783932.JavaMail.itn@is.intellij.net...

This keeps hapening to me but I can't seem to reproduce it intentinaly.

Has anybody else been seeing this.

I am using my AccuRev plugin and calling the default implementations for

the change reporting provides
>

return LocalVcsServices.getInstance(myProject).getFileStatusProvider(); > } > > public UpToDateRevisionProvider getUpToDateRevisionProvider() { > return LocalVcsServices.getInstance(myProject).getUpToDateRevisionProvider(); > } > > public boolean markExternalChangesAsUpToDate() { > return true; > }]]>
Has anybody else been seeing this?



0
Comment actions Permalink

I did too in the Clearcase plugin and like you had not a way to reproduce
it.

Jacques


0
Comment actions Permalink

This is very bad. It happened to 5 people in the past week at my work. Every time it isn't reproduceable. Every time we loose everything. This makes LVCS batching of VCS operations useless.
Olesya would it be possible to turn on logging if any relevant exists or add new ones for the next build to help diagnose this?

Thanks

Jacques

0
Comment actions Permalink

This has been fixed in the build 920. What info would you like to see in the
log?

--
Best regards,
Olesya Smirnova
JetBrains, Inc / IntelliJ Software
http://www.intellij.com
"Develop with pleasure!"


"Jacques Morel" <jacmorel@yahoo.com> wrote in message
news:2674834.1062812219236.JavaMail.itn@is.intellij.net...

This is very bad. It happened to 5 people in the past week at my work.

Every time it isn't reproduceable. Every time we loose everything. This
makes LVCS batching of VCS operations useless.

Olesya would it be possible to turn on logging if any relevant exists or

add new ones for the next build to help diagnose this?
>

Thanks

>

Jacques



0
Comment actions Permalink

Always ahead of the game as usual ;)
Well I do not need anything now that you fixed the problem. I wanted more info for YOU to be able to diagnose the problem in the abscence of reproduceable steps. Since it was a major problem for us (making the plugin and Aurora unusable for us) I wanted to make sure that we would not have to wait another build before getting interesting info.

But you fixed it ;)

Jacques

0
Comment actions Permalink

Is there an ETA on next release?

Jacques

0
Comment actions Permalink

Well, I don't know exactly...
But there is the workaround for your problem :)
Override AbstractVCS.shutdown() and do NOT invoke super. It should help.

--
Best regards,
Olesya Smirnova
JetBrains, Inc / IntelliJ Software
http://www.intellij.com
"Develop with pleasure!"


"Jacques Morel" <jacmorel@yahoo.com> wrote in message
news:24308412.1062865233331.JavaMail.itn@is.intellij.net...

Is there an ETA on next release?

>

Jacques



0
Comment actions Permalink

I am already doing this ;-(
I hope that doesn't invalidate your assumption about your fixed problem. I really want this one to be exterminated for good

Thanks for your answer though. We shall wait impatiently...

0
Comment actions Permalink

You should override "shutdown" without super invocation, don't override
"start" or invoke super.start() and rebuild localvcs (your local vcs already
is broken).

--
Best regards,
Olesya Smirnova
JetBrains, Inc / IntelliJ Software
http://www.intellij.com
"Develop with pleasure!"


"Jacques Morel" <jacmorel@yahoo.com> wrote in message
news:27750925.1062876322278.JavaMail.itn@is.intellij.net...

I am already doing this ;-(
I hope that doesn't invalidate your assumption about your fixed problem. I

really want this one to be exterminated for good
>

Thanks for your answer though. We shall wait impatiently...

>


0
Comment actions Permalink

Do you mean like shutdown() I should override start() and do not call super.start() inside it?

0
Comment actions Permalink

No,no,no...
You should call super.start() (or don't override start) and shouldn't call
super.shutdown().

--
Best regards,
Olesya Smirnova
JetBrains, Inc / IntelliJ Software
http://www.intellij.com
"Develop with pleasure!"


"Jacques Morel" <jacmorel@yahoo.com> wrote in message
news:4268977.1062951335907.JavaMail.itn@is.intellij.net...

Do you mean like shutdown() I should override start() and do not call

super.start() inside it?
>


0
Comment actions Permalink

Sorry, Sorry, Sorry
I should have read your email closer.
Thank you Olesya.
You got through my thick brain. Could you also write my code since obviously I cannot understand you or it ;)

Jacques

0
Comment actions Permalink

How do I rebuild local vcs?

0
Comment actions Permalink

You're right!
I should write a bit of code instead of vague explanations...


YourVcs extends AbstractVcs {
...
public void start() throws VcsException {
super.start();
...
}

public void shutdown() throws VcsException {
...
}
...
}

--
Best regards,
Olesya Smirnova
JetBrains, Inc / IntelliJ Software
http://www.intellij.com
"Develop with pleasure!"


"Jacques Morel" <jacmorel@yahoo.com> wrote in message
news:733809.1063025221321.JavaMail.itn@is.intellij.net...

Sorry, Sorry, Sorry
I should have read your email closer.
Thank you Olesya.
You got through my thick brain. Could you also write my code since

obviously I cannot understand you or it ;)
>

Jacques



0
Comment actions Permalink

Clear "vcs" folder in the IDEA system directory.

--
Best regards,
Olesya Smirnova
JetBrains, Inc / IntelliJ Software
http://www.intellij.com
"Develop with pleasure!"


"Joey Edelstein" <no_mail@jetbrains.com> wrote in message
news:6848299.1063026726984.JavaMail.itn@is.intellij.net...

How do I rebuild local vcs?



0
Comment actions Permalink

When the new build comes out with the fix should we get rid of the overides or if we need them call super ?

0
Comment actions Permalink

In the build 922 you should call super or don't override them

--
Best regards,
Olesya Smirnova
JetBrains, Inc / IntelliJ Software
http://www.intellij.com
"Develop with pleasure!"


"Joey Edelstein" <no_mail@jetbrains.com> wrote in message
news:397070.1063086227552.JavaMail.itn@is.intellij.net...

When the new build comes out with the fix should we get rid of the

overides or if we need them call super ?


0
Comment actions Permalink

As a matter of design, it is rather dangerous for an API to rely on people calling the super implementation (unless you want to get support calls ;)
I believe you should implement a Template Method for this in the cases there is a critical operation done in the super class that should not be overridable. That way plugin developers cannot forget to call it (like I did ;-).
This is even more important since we do not have any documentation (even with Ariadna). I am totally ok with no documentation as long as the code enforces its own constraints and is as readeable as possible.

Just my 2 c

Jacques

0
Comment actions Permalink

Right now both start and shutdown methods are empty in the AbstractVcs :)
--
Best regards,
Olesya Smirnova
JetBrains, Inc / IntelliJ Software
http://www.intellij.com
"Develop with pleasure!"


"Jacques Morel" <jacmorel@yahoo.com> wrote in message
news:31056745.1063124500001.JavaMail.itn@is.intellij.net...

As a matter of design, it is rather dangerous for an API to rely on people

calling the super implementation (unless you want to get support calls ;)

I believe you should implement a Template Method for this in the cases

there is a critical operation done in the super class that should not be
overridable. That way plugin developers cannot forget to call it (like I did
;-).

This is even more important since we do not have any documentation (even

with Ariadna). I am totally ok with no documentation as long as the code
enforces its own constraints and is as readeable as possible.
>

Just my 2 c

>

Jacques



0

Please sign in to leave a comment.