Stop run, if maven target executed after make fails.

Hi Andrew,

It should work exactly this way - do not run App if "After make" goal execution fails. You can check it using standard maven test goal, just add a failing test to the module.
Which maven goal do you use? Is it something from custom written plugin goal? Does it terninate process with the correct exit code in case of fail?

If I run:

$ mvn

...

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:1.3:run (instrument-classes) on project undertows: An Ant BuildException has occured: Unable to instrument net/bramp/threads/sleep/QuasarSleepHandler$SleepFiber#run()Ljava/lang/Void; because of blocking call to java/lang/Thread#sleep(J)V -> [Help 1]

...

$ echo $?

1

Ah but you may be onto something, if I run:

$ mvn antrun:run

$ echo $?

I always get zero. This is the target I'm telling IntelliJ to run after make.   I will continue to investigate, why running the target directly seems to not produce the error.

Ok, resolved my issue now. This was a maven configuration mistake. When the target was ran specifically from the command line, it did not actually do its job, thus didn't return an error.

For future reference, I had maven config that looked like:

<plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-antrun-plugin</artifactId>

    <executions>
        <execution>
            <id>instrument-classes</id>
            <phase>process-classes</phase>

            <configuration>
                <tasks>
                    <property name="ant_classpath" refid="maven.dependency.classpath"/>
                    <taskdef name="instrumentationTask" classname="co.paralleluniverse.fibers.instrument.InstrumentationTask"
                             classpath="${ant_classpath}"/>
                    <instrumentationTask>
                        <fileset dir="${project.build.directory}/classes/" includes="**/*.class"/>
                    </instrumentationTask>
                </tasks>
            </configuration>

            <goals>
                <goal>run</goal>
            </goals>
        </execution>

But due to the non defaut ID listed, that config wouldn't be used when running directly from the CLI.  Now I've transformed my maven to drop the executions section:

<plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-antrun-plugin</artifactId>

    <configuration>
        <tasks>
            <property name="ant_classpath" refid="maven.dependency.classpath"/>
            <taskdef name="instrumentationTask" classname="co.paralleluniverse.fibers.instrument.InstrumentationTask"
                     classpath="${ant_classpath}"/>
            <instrumentationTask>
                <fileset dir="${project.build.directory}/classes/" includes="**/*.class"/>
            </instrumentationTask>
        </tasks>
    </configuration>

and that seems to work a lot better, with Intellij now halting if that plugin throws an error.