Code reformat - 3193

It looks the code reformat is even more broken than it was in 3177 {:-)

Not only are the opening { being indented one leve, the closing } are being outdented to the left hand margin now.

Nick

18 comments
Comment actions Permalink

It's starting to get beyond annoying that they haven't fixed this yet.

Nick Pratt wrote:

It looks the code reformat is even more broken than it was in 3177 {:-)

Not only are the opening { being indented one leve, the closing } are being outdented to the left hand margin now.

Nick


--
"A man's ethical behavior should be based effectually on sympathy,
education, and social ties and needs; no religious basis is necessary.
Man would indeed be in a poor way if he had to be restrained by fear of
punishment and hope of reward after death."
[Albert Einstein, "Religion and Science", New York Times Magazine, 9
November 1930]

0
Comment actions Permalink

Maybe they offshored development of IDEA?

Quality of EAP builds/process has gone down significantly. I'm at the point
of being very picky about what features I use. I no longer trust Refactor
related stuff, for example.


"Brad" <brad@dontuse.com> wrote in message
news:ctdogn$h6q$1@is.intellij.net...

It's starting to get beyond annoying that they haven't fixed this yet.

>

Nick Pratt wrote:

It looks the code reformat is even more broken than it was in 3177 {:-)

>

Not only are the opening { being indented one leve, the closing } are

being outdented to the left hand margin now.

>

Nick

>

>

--
"A man's ethical behavior should be based effectually on sympathy,
education, and social ties and needs; no religious basis is necessary.
Man would indeed be in a poor way if he had to be restrained by fear of
punishment and hope of reward after death."
[Albert Einstein, "Religion and Science", New York Times Magazine, 9
November 1930]



0
Comment actions Permalink


"Michael Morett" <michaelmorett@yahoo.com> wrote in message
news:cte1ed$73e$1@is.intellij.net...

Maybe they offshored development of IDEA?

>

Quality of EAP builds/process has gone down significantly. I'm at the

point

of being very picky about what features I use. I no longer trust Refactor
related stuff, for example.


Michael,
would you please stop speculating about our near death? I think all IDEA
developers are really annoyed by constant complaints
on bugs in EAP builds. Let me remind you that bugfree EAP is not our primary
goal and never has been. This has been discussed several
times on these forums.

Coming to the original post, yes, the bugs in code formatter bother us, JB
developers, not less that EAPers. However, the situation in the team is such
that
many subsystems in IDEA (code formatter among them) have changed their
owners recently, so we need to be patient, and wait while the new developers
get
familiar with existing code before they make any massive refactorings in it.

And, no, IDEA refactorings stuff has not undergone any changes, so I don't
see any reasons for you not to trust it.

Cheers,
Eugene.


0
Comment actions Permalink

Hi,
Formating engine must be reworked to support new features like JSP, HTML and additional XML formating. Do you think that such complex task can be done one step without problems?
If you not so brave to use buggy EAP builds use Pallada as I am until Irida become stable enough :)

TIA,
Dmitry

0
Comment actions Permalink

EAP members walk a fine line, Eugene. We are vocal, and we've always been. Everytime something important breaks, we file bugs and mention it on the forum. It's just our way to tell you how important a feature is to us.

It was neven my intention, and it will never be, to bash or criticize JetBrains, and if it sounded like that, please pardon me. JetBrains and EAP members are like two long time friends: we can curse at each other all the time, and yet we don't really mean it :)

0
Comment actions Permalink

ditto

Marcus Brito wrote:

EAP members walk a fine line, Eugene. We are vocal, and we've always been. Everytime something important breaks, we file bugs and mention it on the forum. It's just our way to tell you how important a feature is to us.

It was neven my intention, and it will never be, to bash or criticize JetBrains, and if it sounded like that, please pardon me. JetBrains and EAP members are like two long time friends: we can curse at each other all the time, and yet we don't really mean it :)


--
"A man's ethical behavior should be based effectually on sympathy,
education, and social ties and needs; no religious basis is necessary.
Man would indeed be in a poor way if he had to be restrained by fear of
punishment and hope of reward after death."
[Albert Einstein, "Religion and Science", New York Times Magazine, 9
November 1930]

0
Comment actions Permalink

It's Sunday morning and maybe I need my coffee to think more clearly, but
I'm scratching my head trying to figure out the "would you please stop
speculating about our near death" thing. So I did a search on my posts
since Irida started and my first post is 11/4/2004. I don't see where I
said anything that can be remotely interpreted as speculating about JB's
near death. Complaints about bugs? Yes. Some frustration with paticular
builds? Yes. Comments about perception of quality of latest builds? Yes.
Speculating about their near death? I just dont see it. Maybe Evgueny is
confusing me with someone else. That's the only thing I can think of.

It's ironic. I'm huge fan of JB. Probably one of their biggest
cheerleaders. The last thing I want is for them to fail. Maybe my praise
for IDEA isn't heard on this group or head often enough, but it's heard at
the office. I should be more sensitive, however, that constant negative
feedback can have a corrosive effect on morale. And on another thread on
JSP coloring, Marcus pointed out that the comment I made on a bug was in
fact a long time bug that was known about. I should do a better job of
searching for existing bugs before introducing a comment that it is a new
bug.

I think Marcus' comment on "We are vocal, and we've always been. Everytime
something important breaks, we file bugs and mention it on the forum. It's
just our way to tell you how important a feature is to us." is very true.
For example, all JB has to do is break J2EE functionality and watch Robert
S. Sfeir come out screaming. It's funny to watch. Robert really, really
takes the J2EE functionality seriously. But his intention is sincere. As
is mine. I think all of us are sincere.

Evgueny, setup a PayPal account. Let me stuff a few dollars in that account
to buy you beer.


"Brad" <brad@dontuse.com> wrote in message
news:ctj5m6$sq1$1@is.intellij.net...

ditto

>

Marcus Brito wrote:

EAP members walk a fine line, Eugene. We are vocal, and we've always

been. Everytime something important breaks, we file bugs and mention it on
the forum. It's just our way to tell you how important a feature is to us.

>

It was neven my intention, and it will never be, to bash or criticize

JetBrains, and if it sounded like that, please pardon me. JetBrains and EAP
members are like two long time friends: we can curse at each other all the
time, and yet we don't really mean it :)
>

--
"A man's ethical behavior should be based effectually on sympathy,
education, and social ties and needs; no religious basis is necessary.
Man would indeed be in a poor way if he had to be restrained by fear of
punishment and hope of reward after death."
[Albert Einstein, "Religion and Science", New York Times Magazine, 9
November 1930]



0
Comment actions Permalink

Could you please attach your code style settings and code fragment to be
reformatted? And java parameters to run IDEA, please

--
Olesya Smirnova
Developer
JetBrains, Inc
http://www.jetbrains.com
"Develop with pleasure!"

"Nick Pratt" <no_mail@jetbrains.com> wrote in message
news:29506619.1106928184541.JavaMail.itn@is.intellij.net...

It looks the code reformat is even more broken than it was in 3177 {:-)

>

Not only are the opening { being indented one leve, the closing } are

being outdented to the left hand margin now.
>

Nick

>


0
Comment actions Permalink

In article <ctj9pu$kl2$1@is.intellij.net>,
"Michael Morett" <michaelmorett@yahoo.com> wrote:

For example, all JB has to do is break J2EE functionality and watch Robert
S. Sfeir come out screaming. It's funny to watch. Robert really, really
takes the J2EE functionality seriously. But his intention is sincere. As
is mine. I think all of us are sincere.


ROFL! (embarrassing too isn't it? fitting that my gmail account name is
yosemitesam, isn't it? hahahaha)

R

0
Comment actions Permalink

Michael,
I'm really sorry, I didn't want you to understand me literally. Probably
it's the problem with my English, anyway I didn't mean to hurt your feelings
about JB.
I'm just too sensitive about comments on our work, and when you claim that
refactorings do not work, I, as a refactoring guy nowadays, feel rather
depressed (though I probably have not enough reasons due to little work I've
done yet:) So all I wanted to say is "please don't make a far going
conclusions from the fact that some functionality is broken in a particular
build" (though I said another thing, I know, please excuse me once more).

Eugene.


"Michael Morett" <michaelmorett@yahoo.com> wrote in message
news:ctj9pu$kl2$1@is.intellij.net...

It's Sunday morning and maybe I need my coffee to think more clearly, but
I'm scratching my head trying to figure out the "would you please stop
speculating about our near death" thing. So I did a search on my posts
since Irida started and my first post is 11/4/2004. I don't see where I
said anything that can be remotely interpreted as speculating about JB's
near death. Complaints about bugs? Yes. Some frustration with paticular
builds? Yes. Comments about perception of quality of latest builds?

Yes.

Speculating about their near death? I just dont see it. Maybe Evgueny is
confusing me with someone else. That's the only thing I can think of.

>

It's ironic. I'm huge fan of JB. Probably one of their biggest
cheerleaders. The last thing I want is for them to fail. Maybe my praise
for IDEA isn't heard on this group or head often enough, but it's heard at
the office. I should be more sensitive, however, that constant negative
feedback can have a corrosive effect on morale. And on another thread on
JSP coloring, Marcus pointed out that the comment I made on a bug was in
fact a long time bug that was known about. I should do a better job of
searching for existing bugs before introducing a comment that it is a new
bug.

>

I think Marcus' comment on "We are vocal, and we've always been. Everytime
something important breaks, we file bugs and mention it on the forum. It's
just our way to tell you how important a feature is to us." is very true.
For example, all JB has to do is break J2EE functionality and watch Robert
S. Sfeir come out screaming. It's funny to watch. Robert really, really
takes the J2EE functionality seriously. But his intention is sincere. As
is mine. I think all of us are sincere.

>

Evgueny, setup a PayPal account. Let me stuff a few dollars in that

account

to buy you beer.

>
>

"Brad" <brad@dontuse.com> wrote in message
news:ctj5m6$sq1$1@is.intellij.net...

ditto

>

Marcus Brito wrote:

EAP members walk a fine line, Eugene. We are vocal, and we've always

been. Everytime something important breaks, we file bugs and mention it on
the forum. It's just our way to tell you how important a feature is to us.

>

It was neven my intention, and it will never be, to bash or criticize

JetBrains, and if it sounded like that, please pardon me. JetBrains and

EAP

members are like two long time friends: we can curse at each other all the
time, and yet we don't really mean it :)
>

--
"A man's ethical behavior should be based effectually on sympathy,
education, and social ties and needs; no religious basis is necessary.
Man would indeed be in a poor way if he had to be restrained by fear of
punishment and hope of reward after death."
[Albert Einstein, "Religion and Science", New York Times Magazine, 9
November 1930]

>
>


0
Comment actions Permalink

No worries Eugene. No offense taken at all. Honestly.

I will do my part to take more time to make sure that something I claim to
be a bug really is a new bug. As developers, on this we can agree. I would
hate to have people claim something I wrote contains a bug when in fact it
is fine.

I've used a few refactorings in the last two days and no problems to report
at all (3193).

No need to feel depressed. Look on the bright side...you're focused on
Refactorings. You won't have to feel the wrath of Robert S. Sfeir when J2EE
stuff breaks.

:)




"Eugene Vigdorchik (JetBrains)" <ven@jetbrains.com> wrote in message
news:ctjieg$d4s$1@is.intellij.net...

Michael,
I'm really sorry, I didn't want you to understand me literally. Probably
it's the problem with my English, anyway I didn't mean to hurt your

feelings

about JB.
I'm just too sensitive about comments on our work, and when you claim that
refactorings do not work, I, as a refactoring guy nowadays, feel rather
depressed (though I probably have not enough reasons due to little work

I've

done yet:) So all I wanted to say is "please don't make a far going
conclusions from the fact that some functionality is broken in a

particular

build" (though I said another thing, I know, please excuse me once more).

>

Eugene.

>
>

"Michael Morett" <michaelmorett@yahoo.com> wrote in message
news:ctj9pu$kl2$1@is.intellij.net...

It's Sunday morning and maybe I need my coffee to think more clearly,

but

I'm scratching my head trying to figure out the "would you please stop
speculating about our near death" thing. So I did a search on my posts
since Irida started and my first post is 11/4/2004. I don't see where I
said anything that can be remotely interpreted as speculating about JB's
near death. Complaints about bugs? Yes. Some frustration with

paticular

builds? Yes. Comments about perception of quality of latest builds?

Yes.

Speculating about their near death? I just dont see it. Maybe Evgueny

is

confusing me with someone else. That's the only thing I can think of.

>

It's ironic. I'm huge fan of JB. Probably one of their biggest
cheerleaders. The last thing I want is for them to fail. Maybe my

praise

for IDEA isn't heard on this group or head often enough, but it's heard

at

the office. I should be more sensitive, however, that constant negative
feedback can have a corrosive effect on morale. And on another thread

on

JSP coloring, Marcus pointed out that the comment I made on a bug was in
fact a long time bug that was known about. I should do a better job of
searching for existing bugs before introducing a comment that it is a

new

bug.

>

I think Marcus' comment on "We are vocal, and we've always been.

Everytime

something important breaks, we file bugs and mention it on the forum.

It's

just our way to tell you how important a feature is to us." is very

true.

For example, all JB has to do is break J2EE functionality and watch

Robert

S. Sfeir come out screaming. It's funny to watch. Robert really,

really

takes the J2EE functionality seriously. But his intention is sincere.

As

is mine. I think all of us are sincere.

>

Evgueny, setup a PayPal account. Let me stuff a few dollars in that

account

to buy you beer.

>
>

"Brad" <brad@dontuse.com> wrote in message
news:ctj5m6$sq1$1@is.intellij.net...

ditto

>

Marcus Brito wrote:

EAP members walk a fine line, Eugene. We are vocal, and we've always

been. Everytime something important breaks, we file bugs and mention it

on

the forum. It's just our way to tell you how important a feature is to

us.

>

It was neven my intention, and it will never be, to bash or

criticize

JetBrains, and if it sounded like that, please pardon me. JetBrains and

EAP

members are like two long time friends: we can curse at each other all

the

time, and yet we don't really mean it :)
>

--
"A man's ethical behavior should be based effectually on sympathy,
education, and social ties and needs; no religious basis is necessary.
Man would indeed be in a poor way if he had to be restrained by fear

of

punishment and hope of reward after death."
[Albert Einstein, "Religion and Science", New York Times Magazine, 9
November 1930]

>
>

>
>


0
Comment actions Permalink

Robert, you are so funny when things break on the J2EE side. Yosemite Sam?
No. I'd lean towards tasmanian devil. When I read your complaints, I just
sit there laughing. You're polite. But you have a way with words and I
just end up picturing a guy fuming at his desk, cursing at the monitor.
Almost like, "how dare they break this?" So funny.

But you know what...I get a sense of comfort knowing that you're watching
the J2EE side of things. I'd know that when they finally release this
thing, it will have passed "the Robert test".

You add a lot of value. Cheers.



"Robert S. Sfeir" <no_mail@jetbrains.com> wrote in message
news:no_mail-97A076.14332830012005@mail.intellij.net...

In article <ctj9pu$kl2$1@is.intellij.net>,
"Michael Morett" <michaelmorett@yahoo.com> wrote:

>

For example, all JB has to do is break J2EE functionality and watch

Robert

S. Sfeir come out screaming. It's funny to watch. Robert really,

really

takes the J2EE functionality seriously. But his intention is sincere.

As

is mine. I think all of us are sincere.

>

ROFL! (embarrassing too isn't it? fitting that my gmail account name is
yosemitesam, isn't it? hahahaha)

>

R



0
Comment actions Permalink

Maybe they offshored development of IDEA?

Quality of EAP builds/process has gone down
significantly. I'm at the point
of being very picky about what features I use. I no
longer trust Refactor
related stuff, for example.


I've been doing EAP for something like 4 years now (since 2.X), and I can say with certainty, that every EAP release, EAPers complain about the "loss of quality" in EAP builds.

But that every time we go to release, everything is just fine.

It's EAP for a reason. There is nothing wrong with simply sitting on the sidelines for a while. If it really gets anoying, use the production build.

Lately I've actually been using both the EAP and production builds at the same time (some of the plugins I've become addicted to don't work in the EAP yet).

Relax...

The only jobs that are in danger of being offshored if they don't fix the EAP soon are yours and mine :)

Mike

0
Comment actions Permalink

In article <ctj9pu$kl2$1@is.intellij.net>,
"Michael Morett" <michaelmorett@yahoo.com> wrote:

For example, all JB has to do is break J2EE

functionality and watch Robert

S. Sfeir come out screaming. It's funny to watch.

Robert really, really

takes the J2EE functionality seriously. But his

intention is sincere. As

is mine. I think all of us are sincere.


ROFL! (embarrassing too isn't it? fitting that my
gmail account name is
yosemitesam, isn't it? hahahaha)



That's great. And who get's upset when we break the Mac implementation? :)

Hani Suleiman

Can you imagine the fun we would have if Eugene would come out with a post on April first announcing they would drop support for Mac, and are going to charge for J2EE support as a separate plugin :)

Mike


0
Comment actions Permalink

In article <ctjlhk$l03$1@is.intellij.net>,
"Michael Morett" <michaelmorett@yahoo.com> wrote:

Robert, you are so funny when things break on the J2EE side. Yosemite Sam?
No. I'd lean towards tasmanian devil.


Not quite, I don't destroy anything, at least as far as I know I'm not
the one doing the destruction... Yosemite Sam however, when unhappy,
walks around yelling his head off guns drawn looking for the vermit that
cause the problem... and when he can't find start shooting his sixers
put in the air trying to get attention... ;)

R

0
Comment actions Permalink

Michael Kirby wrote:

The only jobs that are in danger of being offshored if they don't fix
the EAP soon are yours and mine :)


But that's only cause there already off-shore ;P

0
Comment actions Permalink

Take a look here, Olesya:

http://www.intellij.net/tracker/idea/viewSCR?publicId=41556

It's been reported agains #3144, but it still behaves exactly the same way on #3193. There's a code fragment on the bug report, and my style settings are attached.

P.S.: (silly joke, don't take it seriously) It's really comforting to know that JetBrains has a woman working on the code style issues. A man just couldn't care so much about style as a woman can. Rest assured, EAP'ers, our code is in good hands.

0
Comment actions Permalink

P.S.: (silly joke, don't take it seriously) It's really comforting to know that JetBrains has a woman working on the code style issues. A man just couldn't care so much about style as a woman can. Rest assured, EAP'ers, our code is in good hands.


+1 :)

0

Please sign in to leave a comment.