CVS - getting a clean copy is too easy

Hi.

I just wanted other peoples oppinion on if they agree with me that getting a clean copy from CVS is a bit too easy in IDEA as it is.

The good thing about it is that it doesn't stay selected if you select it once, the next time you bring up the update dialog the check has been removed.

But the bad thing is that there is no confirmation for getting a clean copy, I mean this will overwrite all your changes, don't you think that IDEA should at least ask you if you're sure you want to do that? I'd think this would be neccessary for people who are unfamiliar with CVS. The confirmation dialog could then have a "Don't show this dialog again" check so that everybody should be happy.

What do you think? Should I file a request?

21 comments
Comment actions Permalink

Yes, file a request. Anything that can destroy existing work should have a warning dialog ....

0
Comment actions Permalink

Well.. it doesn't exactly destroy it. I just saw that IDEA does create a temporary file (".#ClassName.java.1.5" type of file) that contains your old file.

But I still think that a small confirmation dialog should be displayed. That's basically like having a capital C ;o)

So I'll file the request.

0
Comment actions Permalink

Well.. it doesn't exactly destroy it. I just saw that IDEA does create a temporary file (".#ClassName.java.1.5" type of file) that contains your old file.

That's not so bad then ... :)

Still, why go through the chore of renaming loads of files, when a simple dialog could have prevented a mistake?

0
Comment actions Permalink

This is actually a CVS feature. CVS always saves previous version with this funky name pattern when you select a clean copy.

And by the way: I don't think we need another warning here. If you checked "clean copy" then you mean it, by all ways!

0
Comment actions Permalink

And by the way: I don't think we need another warning here. If you checked "clean copy" then you mean it, by all ways!

Well a last warning certainly won't kill anybody IMO, and might save someone a lot of hassle.


0
Comment actions Permalink

...
And by the way: I don't think we need another warning
here. If you checked "clean copy" then you mean it,
by all ways!


Why do you say that? The check box is squeezed in between "Create directories" and "Do not show this dialog in the future" (which, btw, I don't understand why is there... what then happens if I want to get the clean copy one day???).

I check the wrong checkbox all the time when they're close together like that... and as time goes by it gets worse since I get more confidant that I know what I'm doing (I know... stupid me).

My rationale for having the confirmation dialog is that you only do this on very rare occasions so this dialog is not going to degrade your performance in any way... on the contrary, it could save you from headaches later on.

0
Comment actions Permalink

"Do not show this dialog in the future" (which, btw, I don't understand why is there... what then happens if I want to get the clean copy one day???).

LOL! ... :-D

My rationale for having the confirmation dialog is that you only do this on very rare occasions so this dialog is not going to degrade your performance in any way... on the contrary, it could save you from headaches later on.

Absolutely; if we didn't make mistakes, then we wouldn't need debuggers at all ...

0
Comment actions Permalink


Stefan Freyr Stefansson wrote:

I check the wrong checkbox all the time when they're close together like that... and as time goes by it gets worse since I get more confidant that I know what I'm doing (I know... stupid me).


Then why not recommend that the dialog box be redesigned to eliminate
this type of error?

0
Comment actions Permalink

Stefan Freyr Stefansson wrote:

what then happens if I want to get the clean copy one day???


Then you goto Project Properties > VCS Support and select the
appropriate "display dialog box" from the tick box which will have been
deselected by you say "dont show this again".

0
Comment actions Permalink

Because I'd much rather see the confirmation box when you're doing something drastic like getting a clean copy than have the dialog "redesigned" in some way that makes it look ugly. What "redesign" would you suggest that would prevent this? I can't think of any...

0
Comment actions Permalink

...and then when you get that box you check "Get clean copy" and re-check the "Do not display this dialog again" and then two months later you do this all over again... sounds like a usability issue to me!?

0
Comment actions Permalink

"Get clean copy" option will disabled always for the next update (this
option is not persistent).
To view some dialog (hidden with "do not display..." checkbox) you can
invoke action from menu with pressed shift.

--
Best regards,
Olesya Smirnova
JetBrains, Inc / IntelliJ Software
http://www.intellij.com
"Develop with pleasure!"


"Stefan Freyr Stefansson" <stefanf@althingi.is> wrote in message
news:17805011.1065624188899.JavaMail.itn@is.intellij.net...

..and then when you get that box you check "Get clean copy" and re-check

the "Do not display this dialog again" and then two months later you do this
all over again... sounds like a usability issue to me!?


0
Comment actions Permalink

Ok. I knew that it wasn't persistant (which is great by the way... I think I may even have requested that ;o) and it's cool that you can "force" a dialog to appear by holding shift while selecting (although it's a bit unintuitive for those who don't know about it).

But the original issue remains that I think getting the clean copy is a bit too easy to do. Do you have any thoughts on that?

0
Comment actions Permalink

I usually get a clean copy using CVS -> Checkout which warns me if the file
is locally modified, is this any different.

--
Best Regards,
Mamado.

"Stefan Freyr Stefansson" <stefanf@althingi.is> wrote in message
news:32749756.1065607069264.JavaMail.itn@is.intellij.net...

Hi.

>

I just wanted other peoples oppinion on if they agree with me that getting

a clean copy from CVS is a bit too easy in IDEA as it is.
>

The good thing about it is that it doesn't stay selected if you select it

once, the next time you bring up the update dialog the check has been
removed.
>

But the bad thing is that there is no confirmation for getting a clean

copy, I mean this will overwrite all your changes, don't you think that IDEA
should at least ask you if you're sure you want to do that? I'd think this
would be neccessary for people who are unfamiliar with CVS. The
confirmation dialog could then have a "Don't show this dialog again" check
so that everybody should be happy.
>

What do you think? Should I file a request?



0
Comment actions Permalink

My feeling is that it shouldn't be.

But if you do an update and check the "Get clean copy" checkbox then you won't get that warning... it will get a fresh version but it will store the old version that you had in temporary files which is something that "Checkout" probably doesn't do.

0
Comment actions Permalink

Stefan Freyr Stefansson wrote:

although it's a bit unintuitive for those who don't know about it


That could be said about all the features with keyboard shortcuts (eg:
CTRL + ALT + I for indenting, rather than using menus)

0
Comment actions Permalink

I aggree, but this is a bit different though because you can see that Ctrl + Alt + I is the shortcut by looking at the menu item (it says so behind it). The other feature is nowhere to be found "visually" so you'll have to RTFM to figure that one out... but I'm not saying that there is anything that can be done about it. It's just like that (but it's definately good to have it... once you know about it).

0
Comment actions Permalink

Because I'd much rather see the confirmation box when you're doing something drastic like getting a clean copy than have the dialog "redesigned" in some way that makes it look ugly. What "redesign" would you suggest that would prevent this? I can't think of any...


Well, maybe "prevent" is too strong (did I say that?). But I use
smartcvs all day everyday. It has a simple checkbox in its update dialog
for getting a clean copy and does not present a confirmation dialog. I
have never had a problem with that UI. Add to that the fact that cvs
backs up the file and for the once it 1000 time that I might make a
mistake, I see no reason to have a confirmation dialog for the other 999.

Having said that, I have no problem with a confirmation dialog so long
as it can be shut off.

0
Comment actions Permalink

This is how WinCVS works, it's the reason I requested it to begin with ;)

Stefan Freyr Stefansson wrote:

it's cool that you can "force" a dialog to appear by holding shift while selecting (although it's a bit unintuitive for those who don't know about it).


0
Comment actions Permalink

On Wed, 08 Oct 2003 12:51:46 +0000, Stefan Freyr Stefansson wrote:

Why do you say that? The check box is squeezed in between "Create
directories" and "Do not show this dialog in the future" (which, btw, I
don't understand why is there... what then happens if I want to get the
clean copy one day???).


Maybe hide clean ( and maybe some others ) under a hidden "advanced
update" hyperlink that'll reveal the other options....


--
"It's all in the heat of the moment, it's all in the pain..." Devy.
Mark Derricutt @ mark@talios.com @ talios.blog-city.com

0
Comment actions Permalink

Now that's a good suggestion!

I'd be happy with that.

Only thing that I'd worry about then are the novice CVS users that actually don't know what the "Clean copy" means. But they'll probably learn from experience ;o)

0

Please sign in to leave a comment.