What does it mean : "Cannot undo. Some files were changed."


I have the feeling undo is badly broken : it keeps sending this stupid
message :

"Cannot undo. Some files were changed."

Of course, files were changed !! Otherwise, I wouldn't have anything to
undo.

What does this message mean?

Alain

50 comments
Comment actions Permalink

This messasge mean that Local VCS crashed. I try to catch this to send to
Tracker, but can't... It gone. Please send description then you get this to
Tracker.

--
Alexey Efimov, Software Engineer
Sputnik Labs,
http://www.spklabs.com
"Alain Ravet" <alain.ravet.list@wanadoo.be> wrote in message
news:bkv3rl$784$1@is.intellij.net...
>
>

I have the feeling undo is badly broken : it keeps sending this stupid
message :

>

"Cannot undo. Some files were changed."

>

Of course, files were changed !! Otherwise, I wouldn't have anything to
undo.

>

What does this message mean?

>

Alain

>


0
Comment actions Permalink

Alexey Efimov wrote:
> This messasge mean that Local VCS crashed. I try to catch this to
send to
> Tracker, but can't... It gone. Please send description then you get
this to
> Tracker.


On this one, I'm like you : a victim, but no good detective :
http://www.intellij.net/tracker/idea/viewSCR?publicId=12102

It's a major problem anyway, and I don't understand the silence around
it. All I can say is :
?I?m flabbergasted?never has my flabber been so gasted!?.

Alain

0
Comment actions Permalink

yeah, you're not the only one :(. It happens to me also from time to time.

As you mentioned in the bug report, it's only after having undone a few things first that the message pops up. And no signs of exceptions or logs or anything.

I also believe that it will only happen if more than one file has been changed, but I'm not too sure about that.

0
Comment actions Permalink

I'm not using the EAP build, so I don't know if this is happening when it shouldn't. However, in my expreience, the message has appeared only when appropriate. For example, if you have two classes, classes A and B extending class C and both overriding a method "a()" then renaming method "a()" to "b()" will cause both classes to change. Now, if you proceed to modify class B further (type in the editor, for example) and then jump back to class A and try to undo the renaming of method a() -> b() you will get this message since undoing the operation cannot be done safely since the method rename was not the last modification to class B.

0
Comment actions Permalink

Kirk Woll wrote:

I'm not using the EAP build, so I don't know if this is happening when it shouldn't. However, in my expreience, the message has appeared only when appropriate. For example, if you have two classes, classes A and B extending class C and both overriding a method "a()" then renaming method "a()" to "b()" will cause both classes to change. Now, if you proceed to modify class B further (type in the editor, for example) and then jump back to class A and try to undo the renaming of method a() -> b() you will get this message since undoing the operation cannot be done safely since the method rename was not the last modification to class B.


Perhaps the dialog should be reworded with a better explanation of the
problem?

Ciao,
Gordon

--
Gordon Tyler (Software Developer)
Quest Software <http://java.quest.com/>
260 King Street East, Toronto, Ontario M5A 4L5, Canada
Voice: 416-643-4846 | Fax: 416-594-1919

0
Comment actions Permalink

Perhaps the dialog should be reworded with a better explanation of the
problem?


Agree. Any suggestions would be very helpful.

P.S. Something is broken with undo in Aurora so that it shows this "Some
files were changed" when it shouldn't. See
http://www.intellij.net/tracker/idea/viewSCR?publicId=17083

--
Valentin Kipiatkov
JetBrains, Inc
http://www.intellij.com
"Develop with pleasure!"

"Gordon Tyler" <gordon.tyler@quest.com> wrote in message
news:bl1m1h$aac$1@is.intellij.net...

Kirk Woll wrote:

>

I'm not using the EAP build, so I don't know if this is happening when

it shouldn't. However, in my expreience, the message has appeared only when
appropriate. For example, if you have two classes, classes A and B
extending class C and both overriding a method "a()" then renaming method
"a()" to "b()" will cause both classes to change. Now, if you proceed to
modify class B further (type in the editor, for example) and then jump back
to class A and try to undo the renaming of method a() -> b() you will get
this message since undoing the operation cannot be done safely since the
method rename was not the last modification to class B.
>

Perhaps the dialog should be reworded with a better explanation of the
problem?

>

Ciao,
Gordon

>

--
Gordon Tyler (Software Developer)
Quest Software <http://java.quest.com/>
260 King Street East, Toronto, Ontario M5A 4L5, Canada
Voice: 416-643-4846 | Fax: 416-594-1919

>


0
Comment actions Permalink

How about "Cannot undo the change to this file. One or more other files
that were changed by the action you are attempting to undo were modified
since the original action was completed."

A little verbose, but at least it fully explains the situation. Just
out of interest, do you have the information on what files were changed
so they could possibly be displayed?

N.

Valentin Kipiatkov (JetBrains) wrote:
>>Perhaps the dialog should be reworded with a better explanation of the
>>problem?


Agree. Any suggestions would be very helpful.

P.S. Something is broken with undo in Aurora so that it shows this "Some
files were changed" when it shouldn't. See
http://www.intellij.net/tracker/idea/viewSCR?publicId=17083


0
Comment actions Permalink

Actually I think this is actually a bit clearer :
"Cannot undo the change to this file. The action you are attempting to
undo also changed one or more other files which have been modified since
the original action was completed."

Nathan Brown wrote:

How about "Cannot undo the change to this file. One or more other files
that were changed by the action you are attempting to undo were modified
since the original action was completed."

A little verbose, but at least it fully explains the situation. Just
out of interest, do you have the information on what files were changed
so they could possibly be displayed?

N.

Valentin Kipiatkov (JetBrains) wrote:

>>> Perhaps the dialog should be reworded with a better explanation of the
>>> problem?
>>
>>
>>
>> Agree. Any suggestions would be very helpful.
>>
>> P.S. Something is broken with undo in Aurora so that it shows this "Some
>> files were changed" when it shouldn't. See
>> http://www.intellij.net/tracker/idea/viewSCR?publicId=17083
>>


0
Comment actions Permalink

Valentin Kipiatkov (JetBrains) wrote:
>>Perhaps the dialog should be reworded with a better explanation
>> of the problem?
>
> Agree. Any suggestions would be very helpful.

We first need to know what it means/what problem it is supposed to tell
about.

Alain




0
Comment actions Permalink

In article <bl1no8$jqb$1@is.intellij.net>,
"Valentin Kipiatkov \(JetBrains\)" <valentin@intellij.com> wrote:

Perhaps the dialog should be reworded with a better explanation of the
problem?


Agree. Any suggestions would be very helpful.


How about:

This change cannot be undone because other changes
depend on this change.


Or, in a perfect world:

Undoing this change will affect the following code:




0
Comment actions Permalink

Perhaps the dialog should be reworded with a better explanation of the
problem?

>

Agree. Any suggestions would be very helpful.


How about:

1. naming the change that cannot be undone.
2. button to see a list of files affected by the change, with modified files
followed by an asterisk.
3. button to "undo changes to this file only".

Example:

Cannot undo . Files changed by this action have been modified
since the action completed.





0
Comment actions Permalink

"Cannot undo the change to this file. The action you are attempting to
undo also changed one or more other files which have been modified since
the original action was completed."


I like this one. The only objection is against "undo the change to this
file". When user gets this message it always means that the change to be
undone is spanned across multiple files. Any suggestions how to change the
phrase?

--
Valentin Kipiatkov
JetBrains, Inc
http://www.intellij.com
"Develop with pleasure!"


"Nathan Brown" <nedski@yahoo.com> wrote in message
news:bl1r24$8ql$2@is.intellij.net...

Actually I think this is actually a bit clearer :
"Cannot undo the change to this file. The action you are attempting to
undo also changed one or more other files which have been modified since
the original action was completed."

>

Nathan Brown wrote:

>

How about "Cannot undo the change to this file. One or more other files
that were changed by the action you are attempting to undo were modified
since the original action was completed."

>

A little verbose, but at least it fully explains the situation. Just
out of interest, do you have the information on what files were changed
so they could possibly be displayed?

>

N.

>

Valentin Kipiatkov (JetBrains) wrote:

>
>>> Perhaps the dialog should be reworded with a better explanation of the
>>> problem?
>>
>>
>>
>> Agree. Any suggestions would be very helpful.
>>
>> P.S. Something is broken with undo in Aurora so that it shows this

"Some

>> files were changed" when it shouldn't. See
>> http://www.intellij.net/tracker/idea/viewSCR?publicId=17083
>>
>

>


0
Comment actions Permalink

Just
out of interest, do you have the information on what files were changed
so they could possibly be displayed?


Of course we have this information (or at least able to write some code
which will fetch it). However the things are not always that clear. Files
can not only be modified but, for example, deleted. Showing all this stuff
would be too complicated. IMO we should leave undo as simple as possible.
You should probably use Local VCS to deal with complicated cases.

--
Valentin Kipiatkov
JetBrains, Inc
http://www.intellij.com
"Develop with pleasure!"


"Nathan Brown" <nedski@yahoo.com> wrote in message
news:bl1p2m$8ql$1@is.intellij.net...

How about "Cannot undo the change to this file. One or more other files
that were changed by the action you are attempting to undo were modified
since the original action was completed."

>

A little verbose, but at least it fully explains the situation. Just
out of interest, do you have the information on what files were changed
so they could possibly be displayed?

>

N.

>

Valentin Kipiatkov (JetBrains) wrote:
>>Perhaps the dialog should be reworded with a better explanation of the
>>problem?
>
>

Agree. Any suggestions would be very helpful.

>

P.S. Something is broken with undo in Aurora so that it shows this "Some
files were changed" when it shouldn't. See
http://www.intellij.net/tracker/idea/viewSCR?publicId=17083

>

>


0
Comment actions Permalink

OK, how about:
"Cannot undo the last action that changed this file. The action you are
attempting to undo also changed one or more other files which have been
modified since the original action was completed."

or

"Cannot undo the previous action carried out on this file. The action
you are attempting to undo also changed one or more other files which
have been modified since the original action was completed."

Nathan.

Valentin Kipiatkov (JetBrains) wrote:

>>"Cannot undo the change to this file. The action you are attempting to
>>undo also changed one or more other files which have been modified since
>>the original action was completed."


I like this one. The only objection is against "undo the change to this
file". When user gets this message it always means that the change to be
undone is spanned across multiple files. Any suggestions how to change the
phrase?


0
Comment actions Permalink

Ok, we'll take the first one. Thank you very much!

--
Valentin Kipiatkov
JetBrains, Inc
http://www.intellij.com
"Develop with pleasure!"

"Nathan Brown" <nedski@yahoo.com> wrote in message
news:blc9ag$hu0$1@is.intellij.net...

OK, how about:
"Cannot undo the last action that changed this file. The action you are
attempting to undo also changed one or more other files which have been
modified since the original action was completed."

>

or

>

"Cannot undo the previous action carried out on this file. The action
you are attempting to undo also changed one or more other files which
have been modified since the original action was completed."

>

Nathan.

>

Valentin Kipiatkov (JetBrains) wrote:

>

>>"Cannot undo the change to this file. The action you are attempting to
>>undo also changed one or more other files which have been modified since
>>the original action was completed."
>
>

I like this one. The only objection is against "undo the change to this
file". When user gets this message it always means that the change to be
undone is spanned across multiple files. Any suggestions how to change

the

phrase?

>

>


0
Comment actions Permalink

Hey no worries! Every time that text pops up now, the feeling of pride
will help offset the burden of having to pick my way back through what I
just did ;)

Regards,
Nathan.

Valentin Kipiatkov (JetBrains) wrote:

Ok, we'll take the first one. Thank you very much!


0
Comment actions Permalink

Valentin Kipiatkov (JetBrains) wrote:
> IMO we should leave undo as simple as possible.
> You should probably use Local VCS to deal with complicated cases.


I still don't understand the meaning of the message/why it's not a bug :

You can undo a rename refactoring that had effects spanning over many
files.
Could you give an example of a modification spanning multiple files
where is supposed to display this error message?

Alain

0
Comment actions Permalink

Nathan Brown wrote:

OK, how about:
"Cannot undo the last action that changed this file. The action you are
attempting to undo also changed one or more other files which have been
modified since the original action was completed."


"Cannot undo the last action that changed this file. The action you are
attempting to undo HAD also changed one or more files, which have been
modified since."

R

0
Comment actions Permalink

To illustrate:

Say you're editing class A and decide rename a method. Then you switch to
class B, which calls that method and so was affected by the refactoring. Now
you change class B to remove the call to the method in class A. Finally, you
switch back to class A and try to undo the renaming of the method. The undo
will fail, because it can't undo the renaming in class B without affecting
the changes you made to it afterwards.

(I think that's right...)

Vil.

Alain Ravet wrote:

Valentin Kipiatkov (JetBrains) wrote:
> IMO we should leave undo as simple as possible.
> You should probably use Local VCS to deal with complicated cases.


I still don't understand the meaning of the message/why it's not a bug :

You can undo a rename refactoring that had effects spanning over many
files.
Could you give an example of a modification spanning multiple files
where is supposed to display this error message?

Alain


--
Vilya Harvey
vilya.harvey@digitalsteps.com / digital steps /
(W) +44 (0)1483 469 480
(M) +44 (0)7816 678 457 http://www.digitalsteps.com/

Disclaimer

This e-mail and any attachments may be confidential and/or legally
privileged. If you have received this email and you are not a named
addressee, please inform the sender at Digital Steps Ltd by phone on
+44 (0)1483 469 480 or by reply email and then delete the email from
your system. If you are not a named addressee you must not use,
disclose, distribute, copy, print or rely on this email. Although
Digital Steps Ltd routinely screens for viruses, addressees should
check this email and any attachments for viruses. Digital Steps Ltd
makes no representation or warranty as to the absence of viruses in this
email or any attachments.

0
Comment actions Permalink

gaargh, now you've gone and spoiled it for me ;)

But surely it should be : "Cannot undo the last action that changed this
file. The action you are attempting to undo HAS also changed one or
more files, which have been modified since." ?

'had' implies the action has since been reverted, which of course would
be correct if Idea had done what Alain wants and worked out how to do
the undo anyway ;) ... e.g. "The action you just undid HAD also changed
one or more other files, but now they've been reverted too."

N.

Robert S. Sfeir wrote:

Nathan Brown wrote:

>> OK, how about:
>> "Cannot undo the last action that changed this file. The action you
>> are attempting to undo also changed one or more other files which have
>> been modified since the original action was completed."


"Cannot undo the last action that changed this file. The action you are
attempting to undo HAD also changed one or more files, which have been
modified since."

R


0
Comment actions Permalink

Yes that is how I understand it too. However, to play devils advocate
here, why can't the rename be reversed at this point? Going back to A
and executing a rename back to the original name is exactly equivalent
to an undo in this circumstance. Is this what you're getting at Alain?

N.

Vilya Harvey wrote:

To illustrate:

Say you're editing class A and decide rename a method. Then you switch
to class B, which calls that method and so was affected by the
refactoring. Now you change class B to remove the call to the method in
class A. Finally, you switch back to class A and try to undo the
renaming of the method. The undo will fail, because it can't undo the
renaming in class B without affecting the changes you made to it
afterwards.

(I think that's right...)

Vil.

Alain Ravet wrote:

>> Valentin Kipiatkov (JetBrains) wrote:
>> > IMO we should leave undo as simple as possible.
>> > You should probably use Local VCS to deal with complicated cases.
>>
>>
>> I still don't understand the meaning of the message/why it's not a bug :
>>
>> You can undo a rename refactoring that had effects spanning over many
>> files.
>> Could you give an example of a modification spanning multiple files
>> where is supposed to display this error message?
>>
>> Alain
>>


0
Comment actions Permalink

Vilya Harvey wrote:
> To illustrate:

Thanks.

My problem is with the way undo works, allowing you to corrupt the
time-space continuum. I find it completely unlogical, unintuitive,
dangerous, and useful in only very rare occasions.


Undo should simply undo, going back in time, and nothing else.


Alain

0
Comment actions Permalink

The complication is that you have many files, each with their own time
lines, which are tied at certain points... :S So what does it mean to
go back in time?

Alain Ravet wrote:

Vilya Harvey wrote:
> To illustrate:

Thanks.

My problem is with the way undo works, allowing you to corrupt the
time-space continuum. I find it completely unlogical, unintuitive,
dangerous, and useful in only very rare occasions.


Undo should simply undo, going back in time, and nothing else.


Alain


0
Comment actions Permalink

Nathan Brown wrote:

> .. why can't the rename be reversed at this point?

As I replied to Vilya, 'Undo' should simple undo what you've just done,
and not try to corrupt the time-space continuum.

I find the current 'Undo' behaviour unlogical, counter-intuitive and
less effective than ..

Alain

0
Comment actions Permalink

Nathan Brown wrote:

> The complication is that you have many files, each with their own
time
> lines, which are tied at certain points... :S So what does it
mean to
> go back in time?


It means undo what you've just done, step by step, globally, over the
whole project - like LVCS- , and not locally, in 1 editor, 1 file.


Does anybody really prefer the current behaviour, over a global undo
one? I wonder!


Alain

0
Comment actions Permalink

Nathan Brown wrote:

gaargh, now you've gone and spoiled it for me ;)

But surely it should be : "Cannot undo the last action that changed this
file. The action you are attempting to undo HAS also changed one or
more files, which have been modified since." ?


YES! Perfect, now I understand it! :)

R

0
Comment actions Permalink

I just checked my english it should be:

"which have since been modified."

R

0
Comment actions Permalink

Robert S. Sfeir wrote:

> Nathan Brown wrote:
>> it should be : "Cannot undo the last action that changed
>> this file. The action you are attempting to undo HAS also
>> changed one or more files, which have been modified since." ?

> YES! Perfect, now I understand it! :)


It would be simpler/faster to fix (*1) -undo, that to try to find a name
for the current bizarre behaviour.

Alain


*1 : Undo should undo what you've done, shouldn't it, following
your snail trail backwards.

0
Comment actions Permalink

Alain Ravet wrote:

Robert S. Sfeir wrote:

> Nathan Brown wrote:
>> it should be : "Cannot undo the last action that changed
>> this file. The action you are attempting to undo HAS also
>> changed one or more files, which have been modified since." ?

> YES! Perfect, now I understand it! :)


It would be simpler/faster to fix (*1) -undo, that to try to find a name
for the current bizarre behaviour.


yes but if it means taking out cycles, just type in some weird text
about weird behavior, don't make it a full dissitation and we're gonna
be OK. :)

I do agree that hitting undo should generally back step through things
one step at a time no matter how far you've gone, or at least to a level
you want it to remember like 100 steps, including if it's undeleting a
file from VCS.

R

0
Comment actions Permalink

Robert S. Sfeir wrote:

> I do agree that hitting undo should generally back step through things
> .. at least to .. 100 steps,

Why not say
3 days
?

Alain


0

Please sign in to leave a comment.