Robert, let us know how that new build works with web modules.

Unfortunately, I don't have time to mess with it right now.


99 comments
Comment actions Permalink

Brad wrote:

Unfortunately, I don't have time to mess with it right now.


hahaha you guys must think I do! :)

Well, I always do, I'll give it a shot.

R

0
Comment actions Permalink

Brad wrote:

Unfortunately, I don't have time to mess with it right now.


Ok things are getting better.

A couple of things to note...

Although output directories are not required anymore, if you don't set
them for ALL your modules which are dependant on the web module, you'll
get an exception.

Second thing is that J2EE tab shows up on its own now when you add a web
module. However it doesn't show up if you just turn on J2EE support in
the IDE tab. I'm going to file that bug.

It seems web modules behave MUCH better when setup FROM the J2EE tab
using the VERY nice (and still rough) J2EE setup wizard. It even
remembers the right web.xml location if you do it from there. If you
create the web module using the Path method in the IDE settings, then it
has problems there. (Will file this as a bug)

Custom tags don't resolve at all, even with web app setup (like in the
old days). They must still be working hard on it.

I can debug a jsp, however I still can't see the contents of a request
or response object. Still same error, and it's marked as fixed. Gotta
reopen that.

Hope this helps.

R

0
Comment actions Permalink

HOLLY CRAP... BATTMAN!

GUYS, if you have a java module, which has jsp files, NOT in the
webroot, I mean their own module dependant on a web module, the JSPs
DEBUG right there from the JSP page in the module, not in the exploded dir!

There is a bug where if you set the break point before the jsp file
compiles, the little check mark doesn't show up and it won't stop, but
unsetting and resetting the break point fixes that.

MAN! THIS IS SO INCREDIBLY COOL!

HAHA, I can't contain my excitement over this! This is really top notch!

WAY TO GO JETBRAINERS!
R

0
Comment actions Permalink

Robert,
I am having no problems with Taglib resolution with 1050. I am using Spring and JSTL tag libs and they resolve great...once I set the correct path to my web.xml file. Which IDEA still isn't remembering when it's started.

Thanks,
Patrick

0
Comment actions Permalink

Patrick Burleson wrote:

Robert,
I am having no problems with Taglib resolution with 1050. I am using Spring and JSTL tag libs and they resolve great...once I set the correct path to my web.xml file. Which IDEA still isn't remembering when it's started.


You're gonna have to post setup info here, because I've been trying
various combos, and can't get tag libs to work. Are your tag lib defs
in jar files or in a separate directory? Are they in the same dir as
web.xml?

R

0
Comment actions Permalink

Ok,I have web module defined and it's pointed at my webapp dir. The webapp dir is a standard webapp setup with a WEB-INF dir containing a web.xml and a jsp directory holding my jsps. I have .tld files for the tag libs in the WEB-INF directory and I them defined this way in web.xml.

I guess if you don't have the .tld files in your WEB-INF directory, it doesn't work. Which is probably a bug.

If you would like I can try and zip up my directory structure so you can look at it.

Thanks,
Patrick

0
Comment actions Permalink

Patrick Burleson wrote:

Robert,
I am having no problems with Taglib resolution with 1050. I am using Spring and JSTL tag libs and they resolve great...once I set the correct path to my web.xml file. Which IDEA still isn't remembering when it's started.


My tag lib is defined as such in web.xml:

/tags/struts-bean /WEB-INF/tlds/struts-bean.tld My JSP refers to it this way: My web.xml is the one at the root of the web module, where the .iml gets saved, since IDEA still insists on putting it there for now. I can compile the web module, all my files get copied to the right locations in the webroot directory I setup, I can run and debug the app, but if I open the JSPs in either the web module or in the exploded dir, tags show up in red. did you setup a simple web module by any chance where the web module's content directory is the root of project? So if you look at web module you have something like: jsps here WEB-INF lib classes xxx.tld web.xml If so then I don't have mine setup like this, my project is much more complex than that. I have the following dir structure: classes dir jsps dir resources dir tlds dir media dir images dir css dir scripts dir src dir web.xml (for now) Then to set the project up I have the following java modules (non web modules) which are dependants of the web module and output to the webroot location of: jsps . resources /WEB-INF media . My web module has a content dir of the whole project with src as the source dir, the output dir for the src is classes at the root of my project. My exploded dir is one level above the project root. I do that because at some point I'm just going to deploy it directly to the Tomcat Webapp directory. So when my web module is compiled, I end up with: ]]>
jsp files
media files
WEB-INF
web.xml
classes
(files from src compile)
lib
(all dependant libs for web module)
tlds
(all tlds from resource module)

it's nice and clean, but jsps don't resolve yet, and from what I
understand Igor is still working on that... I hope he's not done :)

R

0
Comment actions Permalink

Patrick Burleson wrote:

Ok,I have web module defined and it's pointed at my webapp dir. The webapp dir is a standard webapp setup with a WEB-INF dir containing a web.xml and a jsp directory holding my jsps. I have .tld files for the tag libs in the WEB-INF directory and I them defined this way in web.xml.

I guess if you don't have the .tld files in your WEB-INF directory, it doesn't work. Which is probably a bug.

If you would like I can try and zip up my directory structure so you can look at it.


I get how you're doing this. It's interesting because in previous
builds we had all sorts of problems making the web module the webroot...
hum... let me try that.

I do know that LOTS of people will appreciate your setup being uploaded.
Let me see if I can get mine going, and I can upload my zip too.

R

0
Comment actions Permalink

Robert,
Yes, your setup is much more complex. I have the simple setup from the start of your message. It works this way and I imagine once the guys at JetBrains get a little more time with it, it will work for you too. These guys have made a huge amount of progress on the J2EE side since the 900 series of builds.
Sorry I can't be more helpful for you.

Thanks,
Patrick

0
Comment actions Permalink

I qam going to throw together a more simple project that makes this work since some of the code I have isn't for public consomption...watch this space sometime tomorrow.

Thanks,
Patrick

0
Comment actions Permalink

Robert S. Sfeir wrote:

Patrick Burleson wrote:

>> Ok,I have web module defined and it's pointed at my webapp dir. The
>> webapp dir is a standard webapp setup with a WEB-INF dir containing a
>> web.xml and a jsp directory holding my jsps. I have .tld files for the
>> tag libs in the WEB-INF directory and I them defined this way in web.xml.
>> I guess if you don't have the .tld files in your WEB-INF directory, it
>> doesn't work. Which is probably a bug.
>> If you would like I can try and zip up my directory structure so you
>> can look at it.


I get how you're doing this. It's interesting because in previous
builds we had all sorts of problems making the web module the webroot...
hum... let me try that.


Ok that's one bug fixed here, it seems that now the web module's webroot
can be the same as the exploded directory, it used to be that you could
not do that, and I certainly prefer that for SURE. Please don't change
that jetBrains :)

However, I still can't resolve tags, even with the tags at the root of
WEB-INF.


R

0
Comment actions Permalink

Here is my Zip sample.

I stripped out a lot of files, removed libraries and stuff, but it
should be good enough for everyone to be able to take a peek on how I'm
setting things up.

the one thing that might not work because of a bug is that if you look
at the web module, you will notice that there are no Child associations
checked off. Check them all on and set the values as follows:

jsps output to .
media output to .
resources output to /WEB-INF/classes
src output to /WEB-INF/classes

it might also show that the mesquite library is missing. This is the
library files required for compile.

Sorry didn't include everything, it would have been too big for everyone
to grab. Once I have more time I can clean this up and post it as an
example project.

I trust everyone will follow the GPL license that this project requires,
if you don't agree with the GPL, please don't download and use this.

R



Attachment(s):
mesquite.zip
0
Comment actions Permalink

Hi Robert and others!

Robert S. Sfeir wrote:

Patrick Burleson wrote:

>> Robert,
>> I am having no problems with Taglib resolution with 1050. I am using
>> Spring and JSTL tag libs and they resolve great...once I set the
>> correct path to my web.xml file. Which IDEA still isn't remembering
>> when it's started.


My tag lib is defined as such in web.xml:

<!-- Struts Tag Library Descriptors -->
<taglib>
<taglib-uri>/tags/struts-bean</taglib-uri>
<taglib-location>/WEB-INF/tlds/struts-bean.tld</taglib-location>
</taglib>

My JSP refers to it this way:

<%@ taglib uri="/tags/struts-bean" prefix="bean" %>

My web.xml is the one at the root of the web module, where the .iml gets
saved, since IDEA still insists on putting it there for now.

I can compile the web module, all my files get copied to the right
locations in the webroot directory I setup, I can run and debug the app,
but if I open the JSPs in either the web module or in the exploded dir,
tags show up in red.

did you setup a simple web module by any chance where the web module's
content directory is the root of project? So if you look at web module
you have something like:

<root>
jsps here
WEB-INF
lib
classes
xxx.tld
web.xml

If so then I don't have mine setup like this, my project is much more
complex than that. I have the following dir structure:

<project root>
classes dir
jsps dir
resources dir
tlds dir
media dir
images dir
css dir
scripts dir
src dir
web.xml (for now)

Then to set the project up I have the following java modules (non web
modules) which are dependants of the web module and output to the
webroot location of:
jsps .
resources /WEB-INF
media .

My web module has a content dir of the whole project with src as the
source dir, the output dir for the src is classes at the root of my
project.

My exploded dir is one level above the project root. I do that because
at some point I'm just going to deploy it directly to the Tomcat Webapp
directory. So when my web module is compiled, I end up with:

<web-root>
jsp files
media files
WEB-INF
web.xml
classes
(files from src compile)
lib
(all dependant libs for web module)
tlds
(all tlds from resource module)

it's nice and clean, but jsps don't resolve yet, and from what I
understand Igor is still working on that... I hope he's not done :)

This should work on current build (1050). The only thing is you need to
change mapping from "." -> "/".

IK

--
Igor Kuralenok
Developer
JetBrains Inc.
http://www.jetbrains.com
"Develop with pleasure!"

0
Comment actions Permalink

Igor, are we supposed to be able to resolve jsp tags or are we spinning
our wheels right now? When do you think we will be able to? (And if we
can how?)

Thanks
R

0
Comment actions Permalink

Robert S. Sfeir wrote:

Igor, are we supposed to be able to resolve jsp tags or are we spinning
our wheels right now? When do you think we will be able to? (And if we
can how?)

We implemented web modules support in include/tld resolve in 1036 so I
think we can make them working on current build (1050) by configuring
modules. Have you tried to change dots to slashes? I think this can help
(we have a number of tests which seems to be close to your configuration
and they pass on 1050).

IK


--
Igor Kuralenok
Developer
JetBrains Inc.
http://www.jetbrains.com
"Develop with pleasure!"

0
Comment actions Permalink

Actually I reported that Includes don't work either in 1050. I changed to / and still nothing. I can send you my project if you want to see how it breaks, or post a project here so we can see it work on our machine?

Not only that but the Child Module settings, where things get deployed to still don't get saved. (That's starting to get annoying)

R

0
Comment actions Permalink

Robert S. Sfeir wrote:

Actually I reported that Includes don't work either in 1050. I changed to / and still nothing. I can send you

> my project if you want to see how it breaks
Good idea. I'm looking forward to look at it. Could you please send it
here or to my work address ik at intellij.com.

Thanks,

IK

--
Igor Kuralenok
Developer
JetBrains Inc.
http://www.jetbrains.com
"Develop with pleasure!"

0
Comment actions Permalink

On its way, it's a big file, I included everything so you can run it
like I do... including libraries.

if it's too big for your email, let me know I will put it somewhere
where you can download it.

R

0
Comment actions Permalink

Still no luck for me either. I can get it to work (taglib resolution that
is) but as soon as I close IDEA and reopen, tags are red again.

"Robert S. Sfeir" <robert@codepuccino.com> wrote in message
news:bss01b$odj$1@is.intellij.net...

On its way, it's a big file, I included everything so you can run it
like I do... including libraries.

>

if it's too big for your email, let me know I will put it somewhere
where you can download it.

>

R



0
Comment actions Permalink

Are your tlds directly under WEB-INF? Can you walk-through your setup for
me? I have a similar directory structure and I can't get taglibs to resolve.

"Patrick Burleson" <pbur@yahoo.com> wrote in message
news:16777954.1072740167737.JavaMail.itn@is.intellij.net...

Robert,
Yes, your setup is much more complex. I have the simple setup from the

start of your message. It works this way and I imagine once the guys at
JetBrains get a little more time with it, it will work for you too. These
guys have made a huge amount of progress on the J2EE side since the 900
series of builds.

Sorry I can't be more helpful for you.

>

Thanks,
Patrick

>


0
Comment actions Permalink

I have no problem resolving tag libs. Here's what I have ...

jsps WEB-INF lib tld .tld files web.xml ... The only difference I see is that I'm defining the tags directly in the jsps. I use this form: ]]>

I don't have a separate resource module either.

0
Comment actions Permalink

My tlds are directly under WEB-INF... My structure is:

WEBROOT
WEB-INF
jsps <- jsps in here
*.tld <- tld files in WEB-INF
web.xml <- has all the taglib URLS defined pointing to the tld files in WEB-INF


The only problem I have had is IDEA keeps pointing at the wrong web.xml when I open the project. IDEA seems to assume that web.xml is in the same directory as the Web Module's .iml file. That's not true in my case. Once I set the web module to be pointing at my web.xml, taglibs resolve fine. Does that help?

Thanks,
Patrick

0
Comment actions Permalink

Hmm. I have the exact same setup and it doesn't work for me. I tried
defining the tags like you're doing and still no go. What do you have for
modules? Do you have a java module and a web module? How are they setup?

"Jon Erdman" <no_mail@jetbrains.com> wrote in message
news:17594147.1072794616858.JavaMail.itn@is.intellij.net...

I have no problem resolving tag libs. Here's what I have ...

>

<web root>
jsps
WEB-INF
lib
tld
.tld files
web.xml
...

>

The only difference I see is that I'm defining the tags directly in the

jsps. I use this form:
>

<%@ taglib uri="/WEB-INF/tld/struts-bean.tld" prefix="bean" %>

>

I don't have a separate resource module either.

>


0
Comment actions Permalink

Thanks but no. I've tried resetting the web.xml path a million times. I've
tried moving my web.xml too. Neither works for me. But, I have my tlds under
a tld directory. Maybe that has something to do with it.

"Patrick Burleson" <pbur@yahoo.com> wrote in message
news:20704571.1072794870603.JavaMail.itn@is.intellij.net...

My tlds are directly under WEB-INF... My structure is:

>

WEBROOT
WEB-INF
jsps <- jsps in here
*.tld <- tld files in WEB-INF
web.xml <- has all the taglib URLS defined pointing to the tld files

in WEB-INF
>
>

The only problem I have had is IDEA keeps pointing at the wrong web.xml

when I open the project. IDEA seems to assume that web.xml is in the same
directory as the Web Module's .iml file. That's not true in my case. Once I
set the web module to be pointing at my web.xml, taglibs resolve fine. Does
that help?
>

Thanks,
Patrick

>


0
Comment actions Permalink

Jon Erdman wrote:

I have no problem resolving tag libs. Here's what I have ...

<web root>
jsps
WEB-INF
lib
tld
.tld files
web.xml
...

The only difference I see is that I'm defining the tags directly in the jsps. I use this form:

<%@ taglib uri="/WEB-INF/tld/struts-bean.tld" prefix="bean" %>

I don't have a separate resource module either.


Thanks for the info Jon. I should try that setup, though it defeats
setting up the exploded directory, I am more interested in getting tag
libs to resolve when I have jsps in a separate module. My feeling is
that if the jsps module is a Child of the web module, web.xml being
setup properly, should allow for proper resolution of the tag libs.

I have another project I need to work on, never worked on it in IDEA,
maybe I can set it up as a web module only.

Which makes me think of a question to those who have things working...

Do you have exploded dir, or war setup, or neither?

R

0
Comment actions Permalink

Okay, if I do the "Mark Web Root", it works until I shutdown IDEA. But when
I reopen, it's no longer marked and tags are red again. Did you do anything
special in that area?

"Patrick Burleson" <pbur@yahoo.com> wrote in message
news:20704571.1072794870603.JavaMail.itn@is.intellij.net...

My tlds are directly under WEB-INF... My structure is:

>

WEBROOT
WEB-INF
jsps <- jsps in here
*.tld <- tld files in WEB-INF
web.xml <- has all the taglib URLS defined pointing to the tld files

in WEB-INF
>
>

The only problem I have had is IDEA keeps pointing at the wrong web.xml

when I open the project. IDEA seems to assume that web.xml is in the same
directory as the Web Module's .iml file. That's not true in my case. Once I
set the web module to be pointing at my web.xml, taglibs resolve fine. Does
that help?
>

Thanks,
Patrick

>


0
Comment actions Permalink

I had lots of problems up tp build 1024 (resolving taglibs, settings not
being saved, etc.). When I got build 1035, I recreated my project (all
files, i.e. IPR, IML, IWS) from scratch and everything except for
web.xml path not being stored when edited through paths settings worked.
Don't know if my project files (IPR, IML, IWS) got busted sometime or if
it just started to work in 1035. Didn't try 1050 either. Maybe you could
try this as well (in case you did not try yet).

Michael

Robert S. Sfeir wrote:

Jon Erdman wrote:

>> I have no problem resolving tag libs. Here's what I have ...
>>
>> >> jsps >> WEB-INF >> lib >> tld >> .tld files >> web.xml >> ... >> >> The only difference I see is that I'm defining the tags directly in >> the jsps. I use this form: >> >> >> >>]]> I don't have a separate resource module either.


Thanks for the info Jon. I should try that setup, though it defeats
setting up the exploded directory, I am more interested in getting tag
libs to resolve when I have jsps in a separate module. My feeling is
that if the jsps module is a Child of the web module, web.xml being
setup properly, should allow for proper resolution of the tag libs.

I have another project I need to work on, never worked on it in IDEA,
maybe I can set it up as a web module only.

Which makes me think of a question to those who have things working...

Do you have exploded dir, or war setup, or neither?

R

0
Comment actions Permalink

Brad wrote:

Okay, if I do the "Mark Web Root", it works until I shutdown IDEA. But when
I reopen, it's no longer marked and tags are red again. Did you do anything
special in that area?


Mark Web Root???? WHERE?

R

0
Comment actions Permalink

Dope didn't see the mark webroot! WOW... hum... Ok Setting that allows
the tag libs to resolve, however only inside the webroot itself... not
in another module which depends on the web module.

Igor? Any chance this can happen, or should we expect to always have
the jsps inside the webroot???

R

0
Comment actions Permalink

Does it still work after you close the project and reopen? That seems to be
my problem. When I close the project, none of the settings are saved. I've
looked in the ipr and iml files and don't see where they would be saved
either.

"Robert S. Sfeir" <robert@codepuccino.com> wrote in message
news:bss41s$gie$2@is.intellij.net...

Dope didn't see the mark webroot! WOW... hum... Ok Setting that allows
the tag libs to resolve, however only inside the webroot itself... not
in another module which depends on the web module.

>

Igor? Any chance this can happen, or should we expect to always have
the jsps inside the webroot???

>

R



0

Please sign in to leave a comment.