PyCharm commit window changed 2019.3.3 -> 2020.1 EAP

Answered

The "Commit..." window in PyCharm (2020.1 EAP) is considerably different than the same window in PyCharm (2019.3.3).  I am opening both of these with the Ctrl-K hotkey or pressing the green checkbox icon in the Git toolbar.  Among the drawbacks:

  • Pressing escape doesn't close the window
  • Side-by-side diff isn't displayed in the window.

Is this change intentional or can I reconfigure it to show the same as it did before?  None of the "View Mode" options restored the previous view.  Both of these are floating windows.

 

PyCharm (2020.1):

PyCharm (2019.3.3):

4 comments
Comment actions Permalink

Thank you for the feedback! Could you please elaborate?

> Pressing escape doesn't close the window

It is not a dialog or a separate window, so it does not close. It is a toolwindow now, that behaves like all other toolwindows. So you can just open another toolwindow to browse something as you need, and then return to the Commit toolwindow when needed, and ut will be in the same state you left it.

Could you please clarify what issues does it cause? 

> Side-by-side diff isn't displayed in the window.

Instead, the side-by-side diff is opened in the editor to the right of the modified files list. Doesn't it work for you?

0
Comment actions Permalink

> It is a toolwindow now,

Okay, so I see now this change is deliberate and there is no way to go back to the previous behavior :(

> Could you please clarify what issues does it cause?

The issues are the change in functionality is a drawback.  Particularly, the lack of a side-by-side diff showing what the changes are prevents me from quickly seeing what changes are in a commit and prevents me from being able to quickly change something, should I want to.

> Instead, the side-by-side diff is opened in the editor to the right of the modified files list. Doesn't it work for you?

When I press Ctrl-K, nothing else is opened.  There is no "modified files list" visible, nor do I see how to get such a window.

0
Comment actions Permalink

> There is no "modified files list" visible, nor do I see how to get such a window.

Diff if opened in the editor when a file you want to see the diff for is selected.

If it doesn't, make sure showing the preview diff is enabled - this is the last toggle on the Local Changes toolbar. In fact, it should be enabled by default.

> The issues are the change in functionality is a drawback

Diff is still there, as mentioned above. What else do you consider missing?

 

> So I see now this change is deliberate and there is no way to go back to the previous behavior

The modal dialog is still available. To use it, disable the Commit from Local Changes without showing the Commit dialog option in Settings | Version Control | Commit dialog

0
Comment actions Permalink

> If it doesn't, make sure showing the preview diff is enabled - this is the last toggle on the Local Changes toolbar. In fact, it should be enabled by default.

After enabling this, I now see the diffs pop up as expected. :)  I do not believe it was enabled by default for me, although I can't be 100% certain I didn't misclick something.

> The modal dialog is still available. To use it, disable the Commit from Local Changes without showing the Commit dialog option in Settings | Version Control | Commit dialog

Ahh, I was not aware of the "Commit from Local Changes" option.  Disabling this restored the previous functionality.

Problem solved.  It seems the settings weren't preserved switching between versions which caused the issue for me, which is now resolved.

Thanks for the help.

0

Please sign in to leave a comment.