Where did AndroidModuleModel.findProductFlavor go? My plugin throws NoSuchMethodError

Answered

Created June 16, 2021 21:13

I am the author of this plugin and it has been working well up until now.

The method AndroidModuleModel.findProductFlavor() existed and works on Androd Studio 4.1, but when upgrading to 4.2.1 my users (and me) are experiencing an exception:

2021-06-16 23:04:54,348 [ 157042] ERROR - llij.ide.plugins.PluginManager - 'com.android.builder.model.ProductFlavorContainer com.android.tools.idea.gradle.project.model.AndroidModuleModel.findProductFlavor(java.lang.String)' 
java.lang.NoSuchMethodError: 'com.android.builder.model.ProductFlavorContainer com.android.tools.idea.gradle.project.model.AndroidModuleModel.findProductFlavor(java.lang.String)'
at com.nilsenlabs.flavormatrix.models.MyProductFlavor.findInModule(MyProductFlavor.java:18)

In the master branch for the source code for the android plugin of IDEA, it seems to still be there though! What's going on here?

Actually when I debug the code and run the line in the inspector using JAVA instead of KOTLIN, I'm getting that the code returns a object of type "IdeProductFlavorContainerImpl". However I can't find any way to reference that class in the source code. It does not resolve nor compile.

Please help. My plugin broke in production and I don't know how to fix it

My build environment is IntelliJ IDEA community edition 2020.2.4, Build #IC-202.8194.7

The original target version was Android Studio version 193.6911.18

I've tried updating the target version to 202.7660.26 (Android Studio 4.2.1) to no avail. I've also tried upgrading to org.jetbrains.intellij plugin to v1.0.

5 comments

Andrei Kuznetsov

Created June 17, 2021 23:20

Hi Frode,

IDEA only has Android Plugin 4.2 on the board. 4.2.1 sources are not merged yet.
Sources for 4.2.1 are not published yet. When published, there will be a new tag `studio-4.2.1` available here: https://android.googlesource.com/platform/tools/adt/idea/+refs
GitHub (https://github.com/JetBrains/android) is dead. Primary repo (https://android.googlesource.com/platform/tools/adt/idea ) now contains a file of 120 MB in the history, and GitHub refuses such a huge blob. Currently up-to-date sources for Android Plugin in IDEA can only be found at https://git.jetbrains.org/?p=idea/android.git;a=summary . GitHub sources froze at version 4.1.
If you target specifically Android Studio, it's probably better to use intellij.localPath pointing to local Android Studio distribution of specific version. Please see https://github.com/JetBrains/gradle-intellij-plugin . This will help to spot the problems in compile time.
Function in question now has different return type:
```
public IdeProductFlavorContainer findProductFlavor(@NotNull String name) {
```
The change has been introduced in this commit by the Google team: https://android.googlesource.com/platform/tools/adt/idea/+/5365877b7833c165e03236e51f0ed154d7e72056

Frode Nilsen

Created June 18, 2021 14:57

Excellent. What do you suggest for me as a resolution? Wait until 4.2.1 sources are merged and published? Or will changing to `intellij.localPath` fix it? (I tried briefly but met some hurdles with a ideaLocal-*.xml that it couldn't write to)

Andrei Kuznetsov

Created June 18, 2021 22:11

I suggest using intellij.localPath and building against real Android Studio distribution. This should fix your problem.

Android Studio and IDEA are two different products independently developed by two different companies (Google and JetBrains). In the context of current issue important difference is the following: IDEA always has the latest platform, but outdated Android plugin. Android Studio always has the latest Android plugin, but outdated platform. For example, IDEA 2020.2 has platform version 202, and android plugin version 4.0. Android Studio 4.2 has platform version 202 and Android plugin version 4.2, IDEA 2021.2 has platform version 212 and android plugin version 4.2.

The function in question has already changed in 4.2, there is no need to wait for 4.2.1 sources.

What kind of problems do you have with the localPath? Just for the record: intellij.version and intellij.localPath should not be specified at the same time.

Frode Nilsen

Created June 19, 2021 06:40

I solved it by runing IDEA as administrator on Windows. Writing to "c:\program files" is a bit protected. The new classes resolve correctly now so I should be able to build and publish a new version. Thanks for great support!

For the record the error I got was:

Could not determine the dependencies of task ':prepareSandbox'.
> Failed to query the value of task ':prepareSandbox' property 'librariesToIgnore'.
> Could not write to file 'C:\Programfiler\android\Android Studio\ideaLocal-AI-202.7660.26.42.7351085-1-withKotlin.xml'.

Andrei Kuznetsov

Created June 19, 2021 08:19

I solved it by runing IDEA as administrator on Windows.

Thank you for information. Alternatively you can use "no-exe" installer (https://developer.android.com/studio#downloads), unpack the Studio to some place where writing is allowed, and use that instance for localPath variable.

Please sign in to leave a comment.