Question about Fleet and Git UI
Hi looked in the forums, but there's no section for Fleet? I added this in Intellij but feel free to move somewhere else
Anyway, trying it out, looks cool, but have two questions about Git commit screen:
1. If you want to check changes, it's now just one endless scroll with all changes in a list. I find this confusing compared to AppCode, Intellij where i click on a file to see changes. Is there a way to get that instead?
2. I do not like that the checkboxes are now to the right. Harder to read and reach IMO. Like it better like it is in other products.
Regarding what i've seen about the UI:
I think it's better to try and stay somewhat consistent with Jetbrains other products. where possible. It's not productive to have to re-learn everything where it doesn't provide clear benefits. (why is there a completely new keymap “fleet”, enabled by default??)
Best of luck with the continued development!
请先登录再写评论。
Thank you for the feedback!
Please follow the issue regarding the "combined diff" feature (it is currently not implemented):
https://youtrack.jetbrains.com/issue/FL-23708/View-the-combined-diff-of-multiple-commits.
The placement of checkboxes to the right is part of Fleet's design, and there's currently no setting to move them to the left as in other JetBrains products. Please feel free to create a feature request for it in our tracker: https://youtrack.jetbrains.com/issues/FL.
What for the keymap, it can be changed to the "classical" one like in IntelliJ IDEA (please find a screenshot of settings attached).
Thank you once again for the feedback, it's valuable for future iterations!:)
Have a good day!
Hi Olga, thanks for response.
Yeah, i did change the keymap, i was just trying to say that for users used to other Jetbrains product, i would argue that it's wiser that default settings (and other common UI workflows) are similar to what users have learned from many years in the rest of the product line. But hey, it's your product! :) I think it looks really promising.
Cheers
Thank you! 🤗️
And have a good day!
Following up on this, i forgot in the summer. The ticket you linked to is not the same thing. This is my issue:
In intellij and other products, the git commit dialog contains a list of files that have changed. Then, below, you see the diff for each file individually when you move up and down in the list.
In fleet, you have a list of changed files to the left, but you basically have the same list to the left again, just that the file selected on the left side is expanded on the right side. If you click around in the list to the left, you quickly have a lot of expanded files to the right.
This makes it really confusing to look at changes because you look at the left and see a selected file, but something completely different is showing to the right.
I want it to work like in the other products, i.e. a selection to the left shows the uncommited changes to that file to the right (or below).
Please have a look at the recording, for me it looks close to what we have in IntelliJ IDEA for example.
Can you please share the screenshot (or screencast) how the diff looks for you and please describe the issue in more details.
Thank you!
I don't see a recording?
Please see attached image where you can see an endless scroll to the right, with an expanded section, followed by two “closed files” followed by another open section etc. You can also see that what i've selected is not what is visible to the right.
In other apps you just see the diff of the file you have actually selected.
I got what you mean. Please try to add the following flag to the settings (Edit Settings JSON file... action):
"ff.expandGitDiffByDefault": false
It will disable the default expanding of the files. And only the selected file will be shown expanded.
Please tell if it solves the issue?
Thank you
Hi, tried it. Not really. Sure, when you go into the section, they are closed in the beginning, which is an improvement.
But as soon as files are clicked on they get expanded, and don't collapse back. Also, if you scroll with the trackpad or wheel you still quickly get lost, since you can scroll past the file you have selected and into something else in the changelist, making you lose track of where you are.
I find this whole UI paradigm confusing and a downgrade.
--
In my opinion, you have the same problem in the settings page. You have your “sections” to the left, but on the right it's just a long list of settings in a mush.
Although, with settings, the selected section at least moves when you scroll up and down in the list to the right, but it's still not great in my opinion.
To summarize, i am arguing that if you have a “select → detail” user interaction, the “select” should control what is visible in the detail, not the other way around. The detail should contain the information about what the user has selected, with a beginning and an end, nothing more. It should not just be an endless property list. that changes what the user has indicated that they want to inspect.