JavaScript Inspection & Intention Power Pack problem

And I have this function

IDEA shows some inspections, but Simplify does nothing and IDEA throws an exception:

Both problems don't exist in Demetra bundled version.

t800t8 wrote:

And I have this function

         function isEnteredParameters() {
>             if (document.login.username.toString().length == 0 && document.login.password.toString().length == 0)  {
>                 return false;
>             }
> 
>             return true;
>         }
> ]]>

IDEA shows some intentions, but Simplify does nothing.

--
Best regards,
Maxim Mossienko
IntelliJ Labs / JetBrains Inc.
http://www.intellij.com
"Develop with pleasure!"

Correct. They exist in lastest version of JavaScript Inspection & Intention Power Pack (release date is June 26, 2006).

IDEA Inspection OpenAPI has slightly changed between version 5.x and 6.0, requiring some adaptations in the plugin code.

A new version of the plugin specific to IDEA-6.0 has thus been released.

Hello Olivier,

Sorry, but I don't quite understand this. JSIntentionPowerPack is bundled
with EAP builds of IDEA 6.0 for several months already, and obviously the
bundled version has all the necessary adaptations.

OD> IDEA Inspection OpenAPI has slightly changed between version 5.x and
OD> 6.0, requiring some adaptations in the plugin code.
OD>
OD> A new version of the plugin specific to IDEA-6.0 has thus been
OD> released.

--
Dmitry Jemerov
Software Developer
http://www.jetbrains.com/
"Develop with Pleasure!"

When I try to install the latest version of JavaScript Inspection & Intention Power Pack (v0.9.3) via Plugin Manager, I have this exception

(ZipFile.java:114)
	at java.util.zip.ZipFile.(ZipFile.java:131)
	at com.intellij.util.io.ZipUtil.isZipContainsFolder(ZipUtil.java:163)
	at com.intellij.ide.plugins.PluginInstaller.prepareToInstall(PluginInstaller.java:67)
	at com.intellij.ide.plugins.PluginInstaller.prepareToInstall(PluginInstaller.java:98)
	... 3 more
]]>

Looks like there is a problem in the "Update" handling. I got an error message when requesting "Update" too, but I didn't get any problem at all while requesting "Uninstall plugin" then "Install plugin" after restarting IDEA.

Dmitry,

The version, which is bundled today with Demetra only contains JavaScript intentions. The plugin goes a step forward, for it contains both intentions and inspections for JavaScript.

The intention API did not change at all between IDEA 5 and 6. That's why the bundled plugin still works fine with IDEA 6 while it was developed using IDEA 5. On the other hand, the inspection API changed a little bit between IDEA 5 and 6 (the LocalQuickFix interface, typically), and also did the way PsiFile instances can be created from a bunch of text. These two OpenAPI changes explain the errors and stack traces t800t8 described above (especially the AbstractMethodError thrown in applyFix()).

Olivier.