[Q] Refactor > Rename remove unused imports.

已回答

Hello, members.

I tried to rename `MAX_SESSIONS_PAGE_SIZE` -> `HOGE_MAX_SESSIONS_PAGE_SIZE` using "Refactor > Rename" menu.
I expected it rename variables only, but It also removed unused imports statement.

Does anyone knows how(or why) to disable "remove import" when I use "Refactor > Rename"?

I know it is better to use "Optimize Import". but This project is not mine. so I want to keeps it.

 

Best regards

The following diff is rename results.

 

diff --git a/digdag-server/src/main/java/io/digdag/server/rs/ProjectResource.java b/digdag-server/src/main/java/io/digdag/server/rs/ProjectResource.java
index 866e7e4a1e..4ac80a4984 100644
--- a/digdag-server/src/main/java/io/digdag/server/rs/ProjectResource.java
+++ b/digdag-server/src/main/java/io/digdag/server/rs/ProjectResource.java
@@ -9,8 +9,6 @@ import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream;
import java.io.BufferedInputStream;
-import java.io.ByteArrayInputStream;
-import java.io.InputStream;
import java.nio.file.Files;
import javax.ws.rs.Consumes;
import javax.ws.rs.Produces;
@@ -20,7 +18,6 @@ import javax.ws.rs.QueryParam;
import javax.ws.rs.HeaderParam;
import javax.ws.rs.PUT;
import javax.ws.rs.DELETE;
-import javax.ws.rs.POST;
import javax.ws.rs.GET;
import javax.ws.rs.NotFoundException;
import javax.ws.rs.WebApplicationException;
@@ -29,25 +26,17 @@ import javax.ws.rs.core.StreamingOutput;
import javax.ws.rs.core.Response;

import com.google.common.base.Strings;
-import com.google.common.base.Supplier;
import com.google.inject.Inject;
-import com.google.common.base.Throwables;
-import com.google.common.collect.*;
import com.google.common.io.ByteStreams;
import com.google.common.base.Optional;
import com.google.common.base.Preconditions;
import com.google.common.collect.ImmutableList;
-import com.google.common.io.ByteStreams;
-import com.google.inject.Inject;
import io.digdag.client.api.RestProject;
import io.digdag.client.api.RestProjectCollection;
-import io.digdag.client.api.RestRevision;
import io.digdag.client.api.RestRevisionCollection;
-import io.digdag.client.api.RestSchedule;
import io.digdag.client.api.RestScheduleCollection;
import io.digdag.client.api.RestSecretList;
import io.digdag.client.api.RestSecretMetadata;
-import io.digdag.client.api.RestSession;
import io.digdag.client.api.RestSessionCollection;
import io.digdag.client.api.RestSetSecretRequest;
import io.digdag.client.api.RestWorkflowDefinition;
@@ -99,30 +88,7 @@ import org.apache.commons.compress.compressors.gzip.GzipCompressorInputStream;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

-import javax.ws.rs.Consumes;
-import javax.ws.rs.DELETE;
-import javax.ws.rs.GET;
-import javax.ws.rs.HeaderParam;
-import javax.ws.rs.InternalServerErrorException;
-import javax.ws.rs.NotFoundException;
-import javax.ws.rs.PUT;
-import javax.ws.rs.Path;
-import javax.ws.rs.PathParam;
-import javax.ws.rs.Produces;
-import javax.ws.rs.QueryParam;
-import javax.ws.rs.WebApplicationException;
-import javax.ws.rs.core.Response;
-import javax.ws.rs.core.StreamingOutput;
-
-import java.io.BufferedInputStream;
-import java.io.IOException;
-import java.io.InputStream;
-import java.io.OutputStream;
-import java.nio.file.Files;
-import java.time.Instant;
-import java.util.List;
import java.util.Map;
-import java.util.stream.Collectors;

import static java.util.Locale.ENGLISH;

@@ -161,7 +127,7 @@ public class ProjectResource
private static final int DEFAULT_ARCHIVE_FILE_SIZE_LIMIT = DEFAULT_ARCHIVE_TOTAL_SIZE_LIMIT;
private static int MAX_ARCHIVE_TOTAL_SIZE_LIMIT;
private static int MAX_ARCHIVE_FILE_SIZE_LIMIT;
- private static int MAX_SESSIONS_PAGE_SIZE;
+ private static int HOGE_MAX_SESSIONS_PAGE_SIZE;
private static final int DEFAULT_SESSIONS_PAGE_SIZE = 100;

private final ConfigFactory cf;
@@ -205,7 +171,7 @@ public class ProjectResource
this.tm = tm;
this.scsp = scsp;
this.projectArchiveLoader = projectArchiveLoader;
- MAX_SESSIONS_PAGE_SIZE = systemConfig.get("api.max_sessions_page_size", Integer.class, DEFAULT_SESSIONS_PAGE_SIZE);
+ HOGE_MAX_SESSIONS_PAGE_SIZE = systemConfig.get("api.max_sessions_page_size", Integer.class, DEFAULT_SESSIONS_PAGE_SIZE);
MAX_ARCHIVE_TOTAL_SIZE_LIMIT = systemConfig.get("api.max_archive_total_size_limit", Integer.class, DEFAULT_ARCHIVE_TOTAL_SIZE_LIMIT);
MAX_ARCHIVE_FILE_SIZE_LIMIT = MAX_ARCHIVE_TOTAL_SIZE_LIMIT;
}
@@ -413,7 +379,7 @@ public class ProjectResource
@QueryParam("page_size") Integer pageSize)
throws ResourceNotFoundException
{
- int validPageSize = QueryParamValidator.validatePageSize(Optional.fromNullable(pageSize), MAX_SESSIONS_PAGE_SIZE, DEFAULT_SESSIONS_PAGE_SIZE);
+ int validPageSize = QueryParamValidator.validatePageSize(Optional.fromNullable(pageSize), HOGE_MAX_SESSIONS_PAGE_SIZE, DEFAULT_SESSIONS_PAGE_SIZE);

return tm.begin(() -> {
ProjectStore ps = rm.getProjectStore(getSiteId());

 

 

1

Hello,

Optimizing imports at rename is the part of Rename Refactoring, so the described behaviour is intended. There is issue already created for this topic, please follow it:
https://youtrack.jetbrains.com/issue/IDEABKL-3561

Thank you

 

0
Avatar
Permanently deleted user

Hello, Olga Klisho

Thank you for replying. I'll follow it.

 

0

请先登录再写评论。