PHP Psi Elements comparison not working

Permanently deleted user

Created June 08, 2017 11:31

Hi,

I'm trying to develop a plugin for PhpStorm but i'm facing some problems with PHP Psi elements. I'm trying to add a LineMarkerProvider for string literals, checking if the parent's element is a StringLiteralExpression, but it always returns false, even when the PsiViewer shows that there are SLE elements in the document.

There is the code (Kotlin) I used to get the element:

private fun getString(element: PsiElement): StringLiteralExpression? {
   val parent = element.parent as? StringLiteralExpression ?: return null
   return parent
}


Any idea ?

4 comments

Artem Khvastunov

Created June 09, 2017 08:21

Official comment

Hi Nicolas,

I'd recommend you to put a breakpoint and take a look at runtime what you get as a parent. Alternatively, you can write something like this

println(element.parent.javaClass)

Permanently deleted user

Created June 09, 2017 09:28

Hi,

I've added some logs, and here the results.*

Code:

println(element.parent::class.java)
println(StringLiteralExpressionImpl::class.java)
println(element.parent::class.java.toString())
println(StringLiteralExpressionImpl::class.java.toString())
println(element.parent::class.java.toString() == StringLiteralExpressionImpl::class.java.toString())
println(element.parent::class.java == StringLiteralExpressionImpl::class.java)

Result

class com.jetbrains.php.lang.psi.elements.impl.StringLiteralExpressionImpl
class com.jetbrains.php.lang.psi.elements.impl.StringLiteralExpressionImpl
class com.jetbrains.php.lang.psi.elements.impl.StringLiteralExpressionImpl
class com.jetbrains.php.lang.psi.elements.impl.StringLiteralExpressionImpl
true
false

I really don't understand what happends.

Artem Khvastunov

Created June 09, 2017 09:33

Please check that php-openapi.jar has a provided scope. It seems it's included in your plugin but it shouldn't be because it's provided by PhpStorm itself.

Permanently deleted user

Created June 09, 2017 09:41

Thanks to you I finally found the problem. It does not come from php-openapi.jar which which already had a provided scope, but from php.jar which I added in the modules. Once I removed it, everything works perfectly.

Thanks for your help.

Please sign in to leave a comment.