The code in that svn project does not seem to be compilable. It looks like it is missing some source files for example these classes cannot be found: com.sixrr.metrics.context.ProjectContext com.sixrr.metrics.context.ScopeSpecifier
On second thought, those files are probably not missing. My current theory is they were removed in a refactoring, but some references remained because the refactoring did not complete properly.
The version of the MetricsReloaded plugin in subversion seems more recent that the version available in the plugin manager. Porting to Diana is straightforward. I will commit some changes later today that should make MetricsReloaded compatible again.
Diana compatible sources are available in svn now. This change touched about 250 different files and was only very lightly tested so I am not uploading the plugin to the plugin repository yet.
Just use the project files included. I have not updated them, but they should work fine. There is also a ant build.xml available, but I have not tested that and do not know if it is in a working state.
If it works on large projects with acceptable performance and with no major bugs, then yes it should be bundled. (Last time I checked both conditions were false.)
The other way round: Bundling it with IDEA to me feels like a promise to take responsibility for performance and bugs...
Personally I don't think it is the most valuable feature to have, but occasionally I would be interested in some metrics for projects. However I think it is quite valuable in a new release for marketing with the enterprise as target group.
Dmitry Jemerov wrote:
Hello Bas,
>>>
>>> >>> Want to become maintainer? :) >>> >> Will you bundle it with IntelliJ IDEA?
Opinions on this are welcome. We can bundle it, but it's we're not sure whether it's worth doing.
You can do handy things with this, I'm sometimes using this to see where we need to focus test creation efforts.
A suggestion for a feature that could use this metrics : create a sort of overlays that combine any of the following - Complexity metrics - Test Coverage - Martin package metrics / Dependency Analysis Matrix
Adding a SVN diff overlay can help to see where there is regression risk since the previous release. The UI would be a nasty one to create I guess.
If it works on large projects with acceptable performance and with no major bugs, then yes it should be bundled. (Last time I checked both conditions were false.)
The other way round: Bundling it with IDEA to me feels like a promise to take responsibility for performance and bugs...
At the moment we don't have much resources internally to allocate to MetricsReloaded improvements, so we'll have to rely on the community for the time being. So if the quality is really not good enough (I haven't yet looked at it in detail myself), this looks like a strong argument against bundling.
-- Dmitry Jemerov Development Lead JetBrains, Inc. http://www.jetbrains.com/ "Develop with Pleasure!"
The zip file containing the relevant jars was too large to attach here. I mailed the files directly to you Taras, a couple of days ago. Perhaps I should just upload the jar to the plugin repository, a buggy plugin may be better than nothing at all. What do you think?
Is the plugin code in the SVN compatible with Diana, or is it still work in progress? Would be convenient if the latest plugin is hosted somewhere, or even added to SVN?
Any chance of getting Metrics Reloaded back on track?
It seems way to valuable to not have it work in Diana.
Any comments?
It would be a big loss if M-R became sort-of abandoned.
If the source available somewhere?
The source of MetricsReloaded is included with the plugin.
Bas
Hello Taras,
http://svn.jetbrains.org/idea/Trunk/Metrics/
Want to become maintainer? :)
--
Dmitry Jemerov
Development Lead
JetBrains, Inc.
http://www.jetbrains.com/
"Develop with Pleasure!"
Let's try to get it to properly run on Diana first
The code in that svn project does not seem to be compilable. It looks like it is missing some source files for example these classes cannot be found:
com.sixrr.metrics.context.ProjectContext
com.sixrr.metrics.context.ScopeSpecifier
Bas
On second thought, those files are probably not missing. My current theory is they were removed in a refactoring, but some references remained because the refactoring did not complete properly.
The version of the MetricsReloaded plugin in subversion seems more recent that the version available in the plugin manager. Porting to Diana is straightforward. I will commit some changes later today that should make MetricsReloaded compatible again.
Bas
Wow Bas, thanks a heap.
I hadn't even had a chance to look at the source yet.
Diana compatible sources are available in svn now. This change touched about 250 different files and was only very lightly tested so I am not uploading the plugin to the plugin repository yet.
Bas
Thanks Bas, will give it a try when I get home.
Are there any special build procedures I should be aware of?
Just use the project files included. I have not updated them, but they should work fine. There is also a ant build.xml available, but I have not tested that and do not know if it is in a working state.
Bas
Will you bundle it with IntelliJ IDEA?
Bas
Hello Bas,
>>
>>
>> Want to become maintainer? :)
>>
Opinions on this are welcome. We can bundle it, but it's we're not sure whether
it's worth doing.
--
Dmitry Jemerov
Development Lead
JetBrains, Inc.
http://www.jetbrains.com/
"Develop with Pleasure!"
If it works on large projects with acceptable performance and with no major bugs,
then yes it should be bundled. (Last time I checked both conditions were false.)
The other way round: Bundling it with IDEA to me feels like a promise to take
responsibility for performance and bugs...
Personally I don't think it is the most valuable feature to have, but occasionally
I would be interested in some metrics for projects.
However I think it is quite valuable in a new release for marketing with the
enterprise as target group.
Dmitry Jemerov wrote:
>>>
>>>
>>> Want to become maintainer? :)
>>>
>> Will you bundle it with IntelliJ IDEA?
You can do handy things with this, I'm sometimes using this to see where we need to focus test creation efforts.
A suggestion for a feature that could use this metrics : create a sort of overlays that combine any of the following
- Complexity metrics
- Test Coverage
- Martin package metrics / Dependency Analysis Matrix
Adding a SVN diff overlay can help to see where there is regression risk since the previous release.
The UI would be a nasty one to create I guess.
btw: Coverity does some related work on this.
Hello Stephen,
At the moment we don't have much resources internally to allocate to MetricsReloaded
improvements, so we'll have to rely on the community for the time being.
So if the quality is really not good enough (I haven't yet looked at it in
detail myself), this looks like a strong argument against bundling.
--
Dmitry Jemerov
Development Lead
JetBrains, Inc.
http://www.jetbrains.com/
"Develop with Pleasure!"
Hi Taras,
Did you have a chance to try it out? Any bugs to report?
Bas
Taras Tielkes wrote:
Hi Bas,
Not yet. Will soon.
T.
Bas,
Please forgive me for being lazy, but can you perhaps attach a jar built from the trunk (if you have one lying around somewhere)?
-tt
The zip file containing the relevant jars was too large to attach here. I mailed the files directly to you Taras, a couple of days ago. Perhaps I should just upload the jar to the plugin repository, a buggy plugin may be better than nothing at all. What do you think?
Bas
Hi Bas,
I've replaced the relevant jar files from the previous version of MR installed in Diana.
However, things still don't work for me.
Before submitting exceptions, can you tell me if the (updated) plugin works for you?
If so, can you provide me with a full package to try?
Regards,
Taras
Is the plugin code in the SVN compatible with Diana, or is it still work in progress? Would be convenient if the latest plugin is hosted somewhere, or even added to SVN?
Thanks,
Sanjiv