Generate hashCode() and equals()

Permanently deleted user

Created May 16, 2007 19:49

Why does IDEA generate this code:

"if(!Arrays.equals(data, binary.data)) return false;

return true;"

instead of

"return Arrays.equals(data, binary.data);"

2 comments

Stephen Friedrich

Created May 16, 2007 19:58

I can't say for sure but it's very probably because the generation creates a line like
if <field-x equals other-field-x> return false;
for each of the fields of the class plus a single line
return true;
at the end.

If you happen to have only a single field in the class you end up with this degenerated form.

You could search Jira for a similar issue (there are quite a couple of issues regarding code generation of equals() and hashCode()) and then vote or create a new issue.

Permanently deleted user

Created May 20, 2007 11:40

Ok, sure, let me rephrase:
Why doesn't IDEA do this for single (or few) fields?

regards,

Messi

Stephen Friedrich wrote:

I can't say for sure but it's very probably because the generation creates a line like
if <field-x equals other-field-x> return false;
for each of the fields of the class plus a single line
return true;
at the end.

If you happen to have only a single field in the class you end up with this degenerated form.

You could search Jira for a similar issue (there are quite a couple of issues regarding code generation of equals() and hashCode()) and then vote or create a new issue.

Please sign in to leave a comment.