Lobbying for a working Undo

+1, I want correct undo too:)

Actually if it weren't so annoying, it would be quite funny, I just got "Undo Move Caret to Line Start?".

Now I'm in state of mood of giving all the donuts I've earned during this
EAP years to you, Vincent!

Thank you very much!!!

-

Maxim Shafirov
JetBrains, Inc
http://www.jetbrains.com
"Develop with pleasure!"

Wow, that would be a lot of donuts! :))

Here's a deal. If you fix it, I'll give you all the donuts back out of sheer
happiness. And if you fix it in the 5.1 branch, I'll double the amount of
donuts in a sign of infinite gratitude ;)

Glad I could help

Vince.

Hello Vincent,

And if you fix it in the 5.1 branch, I'll double the
amount of donuts in a sign of infinite gratitude ;)

Ha-ha! Now I think if I should play in casino more often? I've just doubled
my earnings! :)

Thanks a lot again. That's how ideal bug report should look like.

-

Maxim Shafirov
JetBrains, Inc
http://www.jetbrains.com
"Develop with pleasure!"

Fixed! Woohoo! Let me know where to send the trucks with all the donuts!

Thanks :)))

Um, with all the donuts already in the plans what's the best way to bribe
for a 5.1 EAP? :)

Vince.

Big thanks to Vincent for that awesome testcase! I never managed to
get it reproduceable at all.

@Maxim: can we get a little story about the background of that bug?

Vincent Mallet schrieb:

Fixed! Woohoo! Let me know where to send the trucks with all the donuts!

Thanks :)))

Um, with all the donuts already in the plans what's the best way to bribe
for a 5.1 EAP? :)

Vince.

@Maxim: can we get a little story about the background of that bug?

There was a bug in command merging algorithm. There's CommandProcessor.runUndoTransparentAction(), which shall be merged to any prior commands done except (that's what Vincent had discovered) if modifications done in undo_transparent have actually been made to another document.

Thanks. When is the release of 5.1.2 planned?

Maxim Shafirov schrieb:
>>@Maxim: can we get a little story about the background of that bug?

There was a bug in command merging algorithm. There's CommandProcessor.runUndoTransparentAction(), which shall be merged to any prior commands done except (that's what Vincent had discovered) if modifications done in undo_transparent have actually been made to another document.

Hello Sven,

I think "couple of weeks" would be fair enough estimation.

-

Maxim Shafirov
JetBrains, Inc
http://www.jetbrains.com
"Develop with pleasure!"

Thanks. When is the release of 5.1.2 planned?

Maxim Shafirov schrieb:

>>> @Maxim: can we get a little story about the background of that bug?
>>>
>> There was a bug in command merging algorithm. There's
>> CommandProcessor.runUndoTransparentAction(), which shall be merged to
>> any prior commands done except (that's what Vincent had discovered)
>> if modifications done in undo_transparent have actually been made to
>> another document.
>>

I'm going to semi-hijack this thread and ask another Undo-related question: What's up with that "Cannot undo. Some files were changed." I would really like to know why I get that message sometimes. Even if it's a situation that cannot be avoided or worked around, please at least spruce up the message giving more details such as what action cannot be undone and which files were changed that are preventing the undo.

Thanks,
Gordon

Hello Gordon,

This is planned for Demetra and will be fixed there. It's just not that easy
technically.

-

Maxim Shafirov
JetBrains, Inc
http://www.jetbrains.com
"Develop with pleasure!"

I'm going to semi-hijack this thread and ask another Undo-related
question: What's up with that "Cannot undo. Some files were changed."
I would really like to know why I get that message sometimes. Even if
it's a situation that cannot be avoided or worked around, please at
least spruce up the message giving more details such as what action
cannot be undone and which files were changed that are preventing the
undo.

Thanks,
Gordon

What will be fixed? The actual problem causing the popup message or the paucity of information in the message itself?

Thanks,
Gordon

Hello Gordon,

I think we'll start with more informative message, which in turn will help
to investigate the real problem for sure.

-

Maxim Shafirov
JetBrains, Inc
http://www.jetbrains.com
"Develop with pleasure!"

What will be fixed? The actual problem causing the popup message or
the paucity of information in the message itself?

Thanks,
Gordon

That'll be a good start. I look forward to it :)

Thanks,
Gordon

Hello Gordon,

Done.

-

Maxim Shafirov
JetBrains, Inc
http://www.jetbrains.com
"Develop with pleasure!"