Abstract icon is not 'abstract'
Hello,
Green color is not pretty to use with blue, i guess :)
More, Abstract icon now show that abstract class is a 1/4 of interface and 3/4 of class. It is no good :)
I think, that abstract is some not completed class, so look here for old series of icons:
http://www.intellij.net/servlet/JiveServlet/download/22-47921-600614-2251/icons.png
Also entire thread here:
http://www.intellij.net/forums/thread.jsp?forum=22&thread=47921
Thanks!
请先登录再写评论。
I actually like 3281's abstract icon more than the one proposed here. However, I don't know about the "final" class icon decorator with what I guess is supposed to be a pin? Looks more like a tiny bean to me.
I do not like 'finally' one too. Should it rather be a bolt? :)
-
Maxim Shafirov
http://www.jetbrains.com
"Develop with pleasure!"
Worth a try. The existing pinning and bean decorations make the current version rather overloaded in IDEA. Any other good ideas out there?
Other issues:
The "final" marker is unnecessary on enumerated classes, and should be removed.
Whatever the little diamond in the lower left corner of enumerated classes is presumably unnecessary, and should be removed.
The icon for abstract classes should show an "A", rather than a "C".
Love the lightning bolt for exceptions.
Absolutely love the whole functionality. It took a while, but this is just the sort of incremental change providing great usability improvement that I've come to expect out of IDEA.
--Dave Griffith
I agree. I also was suprised to find that group by type did not group my
abstract classes together. Is that intentional or not?
I like it too, but I was looking forward to seeing a yellow color on these,
much like Marco's original mock-up. http://www.jetbrains.net/jira/browse/IDEADEV-768
This is a great feature indeed. I love anything that uses visuals to convey
information like this.
Tobin
>> I do not like 'finally' one too. Should it rather be a bolt? :)
I kind of like the idea of the class being "bolted down", but I'm not sure
how to convey that in such a small icon. Perhaps small bolts or rivets in
the four corners of the icon?
The only other thought I've had so far is maybe even a different shape instead
of a circle, perhaps a square or something. I don't think I like it, but
I thought I'd throw it out there. IDEA's great artists might be able to
do something cool with it, even if I can't imagine it. =)
Tobin
How about a big 'F' ?
Who says server side programmers cant do GUIs...
How about nothing.
Does knowing that a class is final when looking at the list really add more
info than the clutter an abstract cion adds?
Let's not go overboard and add too many decorations to the list please.
Hello Dave,
DG> The icon for abstract classes should show an "A", rather than a "C".
+1. Anythig that will mark visualy abstract classes. Now it marked by green
arc on blue circle, but
it not evident. Abstract still look like usual class.
Thanks
--
Alexey Efimov, Java Developer
Tops BI
http://www.topsbi.ru
Dotted lines and subtle colour differences are not visible enough.
I resuggest to my old ideas:
http://www.intellij.net/servlet/JiveServlet/download/22-47921-599458-2236/classIconsIdeas.png
, to represent an abstract class as pie where one part is missing. It
fits the concept perfectly, and is very readable/visible.
Alain
Sorry, don't like the missing piece you've proposed for abstract classes. It draws too much attention to an abstract class, breaks the common circle that the others use.
Another reason why abstract with just 'A' alone but without the current 1/4 green pie is that the coloring works for abstract exceptions.
+1 for A in abstracts
+1 for making finals square
-0 for using the lightning for exceptions - in my mind, the lightning
has always been an event...
Dave Griffith wrote:
Tobin Juday wrote:
>> The icon for abstract classes should show an "A", rather than a "C".
I like the idea of using A. It's similar to the I for interfaces. And if
you consider the concepts of 'stable' and 'abstract', as discussed by
Robert C. Martin (Dependency-Inversion Principle, Stable-Dependencies
Principle, Stable-Abstractions Principle), then I think abstract classes
should definitely be grouped together. The ordering should be C -> A ->
I, or the reverse, to indicate increasing abstractness. Since stability
and abstractness are related, this can give a nice visual representation
of how stable your package should be.
--
Rob Harwood
Software Developer
JetBrains Inc.
http://www.jetbrains.com
"Develop with pleasure!"
Hello Rob,
RH> I like the idea of using A. It's similar to the I for interfaces.
Opps, we forget about Aspects...
What icons Aspects?
--
Alexey Efimov, Java Developer
Tops BI
http://www.topsbi.ru
In article <2cac73a93c778c709b7f0a269f7@news.jetbrains.com>,
Alexey Efimov <aefimov@zebra.ru> wrote:
O
Also what's with the final class having what looks like a little turd,
or football on its side. Not sure how that defines final.
R
Although I do not associate a lightning with an event, what about using
an X for eXceptions?
Tom
This thread makes one things clear to me: people want to customize their
icons set.
=> icons should be pluggable.
Alain
They are pluggable. Replace your icons.jar...
-
Maxim Shafirov
http://www.jetbrains.com
"Develop with pleasure!"
Maxim
>> => icons should be pluggable.
>
>
I know, but I meant "easily" pluggable.
For example, they could be distributed as a plugin => load the plugin
from the repository
, or provide a way to replace individual icons.
Alain
Frankly saying, I truly beleive it doesn't worth the time necessary to implement
the stuff.
-
Maxim Shafirov
http://www.jetbrains.com
"Develop with pleasure!"
Maxim
>
You'd just have to add 2 methods to the openAPI
setIcon (resourceId, resourcePath)
String getIconPath (resourceId)
to change the mapping.
The rest, we can do ourselves.
I agree it's low priority though, but the thread activity was surprising
for such a low priority feature.
I haven't seen any reaction from colourblind people; do they find the
current icons set satisfactory?
Alain
In article <c8a8a1bf80118c70a55d2154867@news.jetbrains.com>,
Maxim Shafirov (JetBrains) <max@jetbrains.com> wrote:
I agree, no one is going to spend a lot of time customizing icons.
Sorry, I don't think the fact that people are responding to a thread
with ideas of what the icons should look like means that idea should
have a full blown out UI just to setup icons... come on.
R
From what I can tell, it looks like a pin is stuck into the original class
icon. Perhaps trying to signify that class is now pinned down and unable
to be changed?
Tobin
What's wrong with E?
Tobin
Isn't E used for 5.0 enums?
Vince.
Ahhh, I don't know. I am not using either 5.0 or enums right now. But maybe
I'll look if I get a moment.
Tobin
Or T for Throwable?
Vince.
Exactly
-
Maxim Shafirov
http://www.jetbrains.com
"Develop with pleasure!"
In article <c8a8a1bf805d8c70a81f548099c@news.jetbrains.com>,
Maxim Shafirov (JetBrains) <max@jetbrains.com> wrote:
Hard to tell that. Looks like a football to me :) A lock on the icon
would make more sense.
R